From: Jacky Huang <jackyhuang@nvidia.com>
To: <sashiko-reviews@lists.linux.dev>
Cc: Jacky Huang <jackyhuang@nvidia.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-aspeed@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC
Date: Sat, 4 Jul 2026 04:15:35 +0900 [thread overview]
Message-ID: <20260703191604.2238473-1-jackyhuang@nvidia.com> (raw)
In-Reply-To: <20260702171315.921CF1F000E9@smtp.kernel.org>
On Thu, Jul 02, 2026 at 05:13:13PM +0000, sashiko-bot@kernel.org wrote:
> [Severity: High]
> Since cp2112 devices expose a single HID interface, the kernel's
> usb_of_has_combined_node() assigns the parent device node to the interface
> and skips subnodes.
>
> Should these properties be placed directly on the device node, similar to
> how cp2112c is configured in this same file?
>
> [Severity: High]
> Is this interface subnode for cp2112b susceptible to the same OF node
> combining regression mentioned above?
cp2112a and cp2112b are NVIDIA composite devices that expose 3 USB
interfaces, so usb_of_has_combined_node() returns false and interface@1 is
used.
> [Severity: Low]
> An I2C device at address 0x75 is typically a PCA9539.
This is a PCA9539. Will fix the compatible to nxp,pca9539.
> [Severity: Low]
> An address of 0x38 typically corresponds to a PCA9554A.
The kernel has no nxp,pca9554a compatible, so nxp,pca9554 is used.
Jacky
next prev parent reply other threads:[~2026-07-03 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 16:55 [PATCH 0/2] Add device tree for NVIDIA VR-NVL BMC Jacky Huang
2026-07-02 16:55 ` [PATCH 1/2] dt-bindings: arm: aspeed: Add " Jacky Huang
2026-07-03 9:52 ` Krzysztof Kozlowski
2026-07-02 16:55 ` [PATCH 2/2] ARM: dts: " Jacky Huang
2026-07-02 17:13 ` sashiko-bot
2026-07-03 19:15 ` Jacky Huang [this message]
2026-07-02 17:16 ` Andrew Lunn
2026-07-03 3:31 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703191604.2238473-1-jackyhuang@nvidia.com \
--to=jackyhuang@nvidia.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox