Re: [PATCH v5 5/5] arm64: dts: allwinner: sun55i: add thermal sensors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The GPU thermal zone incorrectly names its trip points node 'gpu-trips' instead of 'trips', causing the thermal core to silently ignore all GPU trip points.
--

commit 2bc13bc055e98065b94ef6b295284d00ab1541b4
Author: Mikhail Kalashnikov <iuncuim@gmail.com>

arm64: dts: allwinner: sun55i: add thermal sensors

This commit adds thermal sensor configuration and thermal zones for the A523
processor, including THS0 and THS1 sensors. It defines trip temperatures,
polling delays, and cooling maps for the CPUs, GPU, and DDR.

> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 5afa8d92acbfb..07ff74a955441 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
[ ... ]
> +		gpu-thermal {
> +			polling-delay-passive = <100>;
> +			polling-delay = <1000>;
> +			thermal-sensors = <&ths1 2>;
> +			sustainable-power = <2400>;
> +
> +			gpu-trips {

[Severity: High]
Will this node name cause the thermal OF framework to skip parsing the GPU
trip points?

Looking at thermal_of_trips_init() in drivers/thermal/thermal_of.c, it
specifically looks for a child node named exactly "trips" using
of_get_child_by_name(np, "trips").

Because this is named "gpu-trips", it appears the GPU trip points will be
silently ignored by the parser. This could leave the GPU without thermal
protection, including the 110-degree critical shutdown threshold. Should
this be renamed to "trips"?

> +				gpu_temp_threshold: gpu-trip-0 {
> +					temperature = <60000>;
> +					type = "passive";
> +					hysteresis = <0>;
> +				};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260704171411.1413349-1-iuncuim@gmail.com?part=5