From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 857FD367285 for ; Sun, 5 Jul 2026 07:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783238323; cv=none; b=Im7BOv3pSshM3/UMnKJ/8vfwCR5pUvXC8S9jALQH/p0LZtcs4W3Wj6z+5n/To15wLLomhVnFkvln0tA65aiiEVt9DcWwrnUws3E2AY4OqTjLT4y4aNXzh/7mpCIC9wdzRN/5FzvXBn2yxyf3jMVFfiZgWSF86vY6ByPdaoTHccc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783238323; c=relaxed/simple; bh=UOdS+ggItBo8Fbxj7Cwq/9AocOYrjMGNU/RcBG7UEQM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Uo7tqI3M5ep93DkQ71X+Y+pRKnXIDiTKnS6bSyoIBlixB9fVXkUMuC5LcRc+Hyady+M+t5WjM73I81EfhFD/gIVg08Ko3ib5IulXnpHFqCdBl78aVqyoMIga0NISymSS+1fNKfwEzaRCL2Hlvt0rpv9s4kdIohSIArrgWCsyPdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CYWuA4CX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CYWuA4CX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49241dbf9c1so18682695e9.2 for ; Sun, 05 Jul 2026 00:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783238320; x=1783843120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8luoQD6yVJJNuYdfTQQskkaqAeRmMzwRB2xqljwPj5g=; b=CYWuA4CXgmmGc3HCRXu7Q17xp2H6REiy9NJb/iHz1N/9IdCkOwGa7gQesUzpaylWQx uMdyq0LfxGsS/HJFlJFQo7uCatURt52ZJK+EIHsMSNJ1WZ+ojQqUMaTiEN458a2/QR2C ccRFr4o3B+8hT6B3nbFcvbI63oROn5KE505SdgNwUp/ylnlJwOsoraEt0ygWv5XpNNS3 jCEij5JcIEEMIPsF/lnHK8PehYnvygRaN5hWQquVZDsNuWozeQN+TDtjhgq5cLsCyH0A k5DQP79siclJXYF5GJYRUFBx2QutzbQjT68cph0VfrFMyXT1Xj7jof8Wyh3Z8OCZAHEs uJUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783238320; x=1783843120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8luoQD6yVJJNuYdfTQQskkaqAeRmMzwRB2xqljwPj5g=; b=C+EqRiEQ6f29ExGZBP02vT21q918Bw45m574LT527ZtQThYj5E4uKnPgdkgqpiVtpu ADnDsR0ut16A3jPLKPdc7LrLcGhUfLKWW9Pklid+0vw5vjmGFAaifTQT83RRxGCfpStZ 0uEdVye+2IYAzZOW4EygLUCI74AU2P6jPXcNkETh4qAspu2SDrSVRLaOt7qf3lz5Ybhb lQu7QbVB7MMm3BmXlfQXj5rebySzYMLEzVdUYLUPcTtJVSnm5j0lkJs8OTFyBCrvADsU /SKJXgAUs00eGqGXO2X66cMCMVaZ2srgOmncXfqYeE2gZ6vIBv93mitPcdUrIhzBMiC+ dMaA== X-Forwarded-Encrypted: i=1; AFNElJ/fejNSeRn9WUYwFq3oWm0NI7REOS4snUCcan59n+8lHa4IJHUInHn+L3l7eF4xE0x3k3o8IUPy+pwg@vger.kernel.org X-Gm-Message-State: AOJu0YyoXHVfNaOLcsyFVMF8sHjpcBTdtZ+wM2r7byGZdOc8QWG+3aqO ElUjA/MZTjxEWhupSDbrPjtKgcElzuQPeOgm38+BHvDq8PEVUzs9pnINaOd9vZAF X-Gm-Gg: AfdE7claZMB6/1Uclu+IO0mcX/Hv1Zo+HQ8Cmu9u42jgtD3vivQa5kTHlJvOZQH0U8L 6QPWBAFl7p8plR4fFItylXSwJmRdihHoUDLarjS/k8TK6z16kVleJdOzuSPtD84qfcRr6c2n6W/ ZZCteb19MC9C+52TCWTqdQIZ1l4MTHxK3wJHzsReMNxsVzG3cVlx4CGrMGwiMAUIQVaOda/LnDz yLCsfMos5B/wo4eX9Wj+kMKlca3hrCb7Fg/Ely6o9qfgcX1KYPjhGghR4mal92zhExw7AKZOM9G nXqb22FHgbmXw3uD/KZnOo7KdG0lt4lJfsNGebEZROQx6eCsxltbaH03HLIKn98Ok9Ob5jyzKlG MrjZWejQqZ3CWlW0uyifuzRMyLlc/NiEIzaeJJurrYaQvsUvLmOe1AZRwX5UIe1pHzUvpiW54uW aHlj5VKlV0lGq6oGI6Oa3LflSHhsjQxS2wJw== X-Received: by 2002:a05:600d:8654:20b0:493:bfea:2786 with SMTP id 5b1f17b1804b1-493d11f6d34mr45957155e9.32.1783238319733; Sun, 05 Jul 2026 00:58:39 -0700 (PDT) Received: from localhost.localdomain ([95.43.220.235]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63bfba1sm305769765e9.15.2026.07.05.00.58.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 00:58:38 -0700 (PDT) From: Ivaylo Dimitrov To: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Linus Walleij , Bartosz Golaszewski Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, Ivaylo Dimitrov Subject: [PATCH v2 1/5] phy: cpcap-usb: Prevent line glitches from triggering sysrq Date: Sun, 5 Jul 2026 10:58:05 +0300 Message-Id: <20260705075809.1793784-2-ivo.g.dimitrov.75@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260705075809.1793784-1-ivo.g.dimitrov.75@gmail.com> References: <20260705075809.1793784-1-ivo.g.dimitrov.75@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We can get random sysrq events on switching from USB to debug serial port mode unless we temporarily disable sysrq on serial line for the mode changes. Suggested-by: Tony Lindgren Signed-off-by: Ivaylo Dimitrov --- drivers/phy/motorola/phy-cpcap-usb.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c index 7cb020dd3423..d1c70c715346 100644 --- a/drivers/phy/motorola/phy-cpcap-usb.c +++ b/drivers/phy/motorola/phy-cpcap-usb.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -413,7 +414,12 @@ static int cpcap_usb_gpio_set_mode(struct cpcap_phy_ddata *ddata, static int cpcap_usb_set_uart_mode(struct cpcap_phy_ddata *ddata) { - int error; + int old_sysrq_mask, error; + + /* Disable sysrq to prevent random sysrq events on line glitches */ + old_sysrq_mask = sysrq_mask(); + if (old_sysrq_mask & 1) + sysrq_toggle_support(old_sysrq_mask & ~1); /* Disable lines to prevent glitches from waking up mdm6600 */ error = cpcap_usb_gpio_set_mode(ddata, CPCAP_UNKNOWN_DISABLED); @@ -445,13 +451,13 @@ static int cpcap_usb_set_uart_mode(struct cpcap_phy_ddata *ddata) /* Enable UART mode */ error = cpcap_usb_gpio_set_mode(ddata, CPCAP_DM_DP); - if (error) - goto out_err; - - return 0; out_err: - dev_err(ddata->dev, "%s failed with %i\n", __func__, error); + if (old_sysrq_mask & 1) + sysrq_toggle_support(old_sysrq_mask); + + if (error) + dev_err(ddata->dev, "%s failed with %i\n", __func__, error); return error; } -- 2.39.5