Re: [PATCH v2 3/3] arm64: dts: qcom: sm7125-samsung: add initial device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing explicit `#include <dt-bindings/input/linux-event-codes.h>` (or `input.h`), relying on fragile transitive inclusion for input macros (`KEY_VOLUMEUP`, `KEY_VOLUMEDOWN`, `EV_SW`, `SW_LID`).
- [Low] The `rmtfs_mem` node is defined without a unit-address but receives a `reg` property in board-specific files, causing a `unit_address_vs_reg` DTC warning.
--

commit 50b01ca3bfe2c4df6217b51c5cea041f5fa4dfb9
Author: Erikas Bitovtas <xerikasxx@gmail.com>

arm64: dts: qcom: sm7125-samsung: add initial device tree

This patch adds the initial device tree support for the Samsung Galaxy A52
and A72 on the Qualcomm SM7125 platform.

> diff --git a/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
> new file mode 100644
> index 0000000000000..512a151fbff93
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
> @@ -0,0 +1,536 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * SM7125 Samsung common device tree source
> + *
> + * Copyright (c) 2026, The Linux Foundation. All rights reserved.
> + */
> +
> +#include <dt-bindings/arm/qcom,ids.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include "sm7125.dtsi"
> +#include "pm6150.dtsi"
> +#include "pm6150l.dtsi"

[Severity: Low]
Does this file need to explicitly include <dt-bindings/input/linux-event-codes.h>?

The gpio-keys and pm6150_resin nodes use input event macros like KEY_VOLUMEUP,
SW_LID, and EV_SW further down in the file. Relying on transitive includes
can cause build failures if the included files are refactored in the future.

[ ... ]
> +		pstore_mem: ramoops@b4600000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xb4600000 0x0 0x100000>;
> +			record-size = <0x40000>;
> +			console-size = <0x40000>;
> +			ftrace-size = <0x40000>;
> +			pmsg-size = <0x40000>;
> +		};
> +
> +		rmtfs_mem: memory {
> +			compatible = "qcom,rmtfs-mem";
> +			qcom,use-guard-pages;
> +			no-map;
> +
> +			qcom,client-id = <1>;
> +			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
> +		};
> +	};

[Severity: Low]
Does defining the base node without a unit-address here cause a warning
when board-specific files append the reg property?

For example, in sm7125-samsung-a52q.dts:

&rmtfs_mem {
	reg = <0x0 0xf4f00000 0x0 0x202000>;
};

Injecting a reg property into a node named "memory" (without an @address
suffix) usually triggers a unit_address_vs_reg dtc warning during compilation.
Should the base node be given a unit-address placeholder to avoid this?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705-sm7125-samsung-v2-0-d3b17005ecb3@gmail.com?part=3