From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] RFC: ARM: dts: ixp4xx: Fix interrupt-map weirdness
Date: Sun, 05 Jul 2026 22:22:18 +0000 [thread overview]
Message-ID: <20260705222218.7B9D51F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260706-ixp4xx-dts-gpio-cells-v1-1-98fa3ba0ad2d@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `#address-cells = <0>;` to the GPIO node breaks dt-schema validation because the binding schema uses `additionalProperties: false` and does not define `#address-cells`.
--
commit 41571606070d7063df98228dc5614c488e017fdc
Author: Linus Walleij <linusw@kernel.org>
RFC: ARM: dts: ixp4xx: Fix interrupt-map weirdness
This commit adds #address-cells = <0>; to the GPIO node in the IXP4xx
device tree to fix a dtc warning related to interrupt-map.
> diff --git a/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi b/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi
> index 0adeccabd4fef..b6ef98a88c4e5 100644
> --- a/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi
> +++ b/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi
> @@ -114,6 +114,7 @@ gpio0: gpio@c8004000 {
> reg = <0xc8004000 0x1000>;
> gpio-controller;
> #gpio-cells = <2>;
> + #address-cells = <0>;
[Severity: Low]
Will this cause a schema validation error during make dtbs_check?
The corresponding YAML schema for this node
(Documentation/devicetree/bindings/gpio/intel,ixp4xx-gpio.yaml) enforces
additionalProperties: false and does not define #address-cells.
Without updating the YAML binding to explicitly permit
"#address-cells": { const: 0 }, the dt-schema validation will report an
unrecognized property error.
> interrupt-controller;
> #interrupt-cells = <2>;
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-ixp4xx-dts-gpio-cells-v1-1-98fa3ba0ad2d@kernel.org?part=1
prev parent reply other threads:[~2026-07-05 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 22:15 [PATCH] RFC: ARM: dts: ixp4xx: Fix interrupt-map weirdness Linus Walleij
2026-07-05 22:22 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260705222218.7B9D51F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linusw@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox