From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAB993FF88C; Mon, 6 Jul 2026 06:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783320794; cv=none; b=fd6Q/zh8NL3OkwJ2trHjne8zOQlM7c2HKrukylKUGXSuIo4J06yeZ7poHNFzBitqlyeMROcCCvS9OHxDVOOrJKmoyhV8eleGhKBIGoqBpkeYDT+69H7vzouzqx3g7r6xl2BZeFNExcYV9ba9X4ggkdFNNPlh/Jf/RfAJAfIOOvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783320794; c=relaxed/simple; bh=izitCg9SRdQqbGJnJ0KAMXXLvPqISrhaLUFRnFyiOxg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hQEVUq1qEX7T+P+FZoQH02vCanoIWn2rP73wl1Hlh0la+wCeTeAF8BUsKjkCv1P+9Kk0fOYp70VV+6Sjte5825XHEfxc2JzyT4gRuhMozHGlwvhcNmPH/6a/gFRiSpixqsYLYVdYLjF9YO/NdqlVL1uG1iAud5++O5+jhExExNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N61PiGho; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N61PiGho" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 582EF1F000E9; Mon, 6 Jul 2026 06:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783320775; bh=GqJKu5gWDZ/UYtVOCDNuBOQs8FjclaKQ1yPzLTbmJLE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=N61PiGho+yEliRWsdlEhUA25Ntfh+uCc1l0dS/x9FiocKW8k7ng0kBwMbOXn88W9A nauN7Kc/AXHmucbexSQC9Cdm6cfQmVBZvikh0Jn65YTcc4ulUnoyHjNtW1j+IWO6xL spxeTlhsJKkFM9eYz3S6v2cMowYtG1NyJ9F6knEpRhxo6JR8cdilsWDIjiPclLL14O aLkyqI54Hl9n5bRKhkW5f4EDNJDvLI/wJiaUgiZUZU0vYpEvuI5uuZDY5JM48EimW2 NKWsN15efn4K30evc46ELHNSqCtUAXAEDHJc3wC0I7jxp76SOOTCnD+Vndl+sWzwnn lVXILi6CroXzQ== Date: Mon, 6 Jul 2026 08:52:51 +0200 From: Krzysztof Kozlowski To: Paul Louvel Cc: Qiang Zhao , "Christophe Leroy (CS GROUP)" , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 04/12] dt-bindings: soc: fsl: qe: Add support of IRQ in QE GPIO Message-ID: <20260706-elfish-cornflower-bullfinch-604e0a@quoll> References: <20260703-qe-pic-gpios-v1-0-6c3e706e27dc@bootlin.com> <20260703-qe-pic-gpios-v1-4-6c3e706e27dc@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260703-qe-pic-gpios-v1-4-6c3e706e27dc@bootlin.com> On Fri, Jul 03, 2026 at 03:30:12PM +0200, Paul Louvel wrote: > Some QE GPIO pins have an associated interrupt line in the QE PIC to > signal state changes on the pin. Add the corresponding > interrupt-controller / nexus properties to the QE GPIO binding. > > Because the GPIO controller does not perform any interrupt handling > itself, a nexus node (interrupt-map) is used to map each GPIO line > supporting IRQ to the parent QE PIC interrupt domain. > > As the QE PIC can be configured to generate an interrupt on either a > high-to-low transition or any change in signal state, three > interrupt-map entries are needed per GPIO pin that can yield an > interrupt (falling, both, and the "none" case which defaults to both in > QE PIC). This overhead is necessary because the interrupt-map-pass-thru > property is not part of the DT specification. > > The interrupt-map property is optional: it is not required for GPIO > banks that have no interrupt capable GPIO line (e.g. port D on MPC8323), > or when interrupt functionality is not used. > > Update the example to show a scenario where each bank supports a > different numbers of IRQs, or no IRQs at all. > > Signed-off-by: Paul Louvel > --- > .../bindings/gpio/fsl,mpc8323-qe-pario-bank.yaml | 69 +++++++++++++++++++++- > 1 file changed, 66 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/fsl,mpc8323-qe-pario-bank.yaml b/Documentation/devicetree/bindings/gpio/fsl,mpc8323-qe-pario-bank.yaml > index 1af99339ff40..0c849a5698f4 100644 > --- a/Documentation/devicetree/bindings/gpio/fsl,mpc8323-qe-pario-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/fsl,mpc8323-qe-pario-bank.yaml > @@ -27,6 +27,17 @@ properties: > "#gpio-cells": > const: 2 > > + "#address-cells": > + const: 0 > + > + "#interrupt-cells": > + const: 2 > + If this has interrupt-cells, then it is a nexus, thus why isn't this also a "interrupt-controller"? > + interrupt-map: > + description: | > + Specifies the mapping of GPIO lines to the parent interrupt controller, as the > + GPIO controller does not do interrupt handling itself. > + > required: > - compatible > - reg > @@ -37,9 +48,61 @@ additionalProperties: false > > examples: > - | > - gpio-controller@1400 { > - compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-pario-bank"; > - reg = <0x1400 0x18>; I don't get why you rewrite existing example instead of adding new one. > + #include > + > + pic: interrupt-controller { > + interrupt-controller; > + #address-cells = <0>; > + #interrupt-cells = <2>; > + }; Drop node, irrelevant. > + > + gpio-controller@1418 { > + #gpio-cells = <2>; > + #address-cells = <0>; > + #interrupt-cells = <2>; > + compatible = "fsl,mpc8323-qe-pario-bank"; > + reg = <0x1418 0x18>; And now you are not following DTS coding style. > gpio-controller; > + interrupt-map = < > + 7 IRQ_TYPE_EDGE_FALLING &pic 4 IRQ_TYPE_EDGE_FALLING > + 7 IRQ_TYPE_EDGE_BOTH &pic 4 IRQ_TYPE_EDGE_BOTH > + 7 0 &pic 4 IRQ_TYPE_NONE > + > + 9 IRQ_TYPE_EDGE_FALLING &pic 5 IRQ_TYPE_EDGE_FALLING > + 9 IRQ_TYPE_EDGE_BOTH &pic 5 IRQ_TYPE_EDGE_BOTH > + 9 0 &pic 5 IRQ_TYPE_NONE > + > + 25 IRQ_TYPE_EDGE_FALLING &pic 6 IRQ_TYPE_EDGE_FALLING > + 25 IRQ_TYPE_EDGE_BOTH &pic 6 IRQ_TYPE_EDGE_BOTH > + 25 0 &pic 6 IRQ_TYPE_NONE > + > + 27 IRQ_TYPE_EDGE_FALLING &pic 7 IRQ_TYPE_EDGE_FALLING > + 27 IRQ_TYPE_EDGE_BOTH &pic 7 IRQ_TYPE_EDGE_BOTH > + 27 0 &pic 7 IRQ_TYPE_NONE > + >; > + }; > + > + gpio-controller@1430 { > #gpio-cells = <2>; So two new examples? But old one was wrong? > + #address-cells = <0>; > + #interrupt-cells = <2>; > + compatible = "fsl,mpc8323-qe-pario-bank"; > + reg = <0x1430 0x18>; > + gpio-controller; > + interrupt-map = < > + 24 IRQ_TYPE_EDGE_FALLING &pic 8 IRQ_TYPE_EDGE_FALLING > + 24 IRQ_TYPE_EDGE_BOTH &pic 8 IRQ_TYPE_EDGE_BOTH > + 24 0 &pic 8 IRQ_TYPE_NONE > + > + 29 IRQ_TYPE_EDGE_FALLING &pic 9 IRQ_TYPE_EDGE_FALLING > + 29 IRQ_TYPE_EDGE_BOTH &pic 9 IRQ_TYPE_EDGE_BOTH > + 29 0 &pic 9 IRQ_TYPE_NONE > + >; > + }; > + > + gpio-controller@1448 { > + #gpio-cells = <2>; > + compatible = "fsl,mpc8323-qe-pario-bank"; Wait, three examples? But isn't this the same as previous one? > + reg = <0x1448 0x18>; > + gpio-controller; > }; > > -- > 2.55.0 >