From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A1B137C11E; Mon, 6 Jul 2026 17:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783358103; cv=none; b=C/5e1SBWRv4DhC6sANmdhPKZe9DeGrBUA61uSzqj6FbDUKVwMOxbVS7uKnqaIGXphzIqVK4iDZ/bDhYXgbnMBv9NLGEQNunjYhNhH/VRFvRE15Dsk1QQwoUJxIVdyVIUj40W781vnVDBFFuG6os+2QYKN5kKvCJFyBHbhXF4G0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783358103; c=relaxed/simple; bh=Cyrg0grsaRMPFMVwBK5PCRBknfGqtG3jJSiGJhjJh10=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pBvUM7zHwdpaZQe+DCYR2pZRNgHqDdXmT3w1RP2UmBCiK5c7iMuCh5/fcJeptWyI3pCqMpFdEJ4uC9rTEfW5o4BFvXIlMDdlERuL5KkzSCluZSQITmu4rxK09IrAY5NRG2j1tLClnc3wnkHYEKLFV1nFUiq+xOWgT7lhJq3i3Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VJFrGpJJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VJFrGpJJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69C1D1F000E9; Mon, 6 Jul 2026 17:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783358101; bh=FLCkRFY/xZawZM4IfpyQEQBqFJQifdjTe2UFwHN+pbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VJFrGpJJi0WdJNBZtw4v4b+k6Zqo9dKSW5u3hd7vNaqe7DRoSA3roX+lo8tzwWPFZ K1TViY4xZvQQiOF8+PF4HjiGkJfplG5LjYwmIzsFKVRG+XxlGYomGz5Vkwq95amvdx 4zKPi5OQvVVaTlisaZtCHrIUvXLxnkqOzbxAnmv8h9TVZgfseJbA5cDFYpTDEV+ySc 5VBBboakFE94TO9Hs6IKFdMnD6xRpVR7ac94ZnKkZ1pzArVTbiuCwyb/j5aliMrWeY b7Zsl7te9dxAspf/EMLA7iwGhksS8dopDR+/KyNe1c+kH8K7eK3tQ/NojTG/Iq6BMT 7oMlJvppDzAnQ== Date: Mon, 6 Jul 2026 18:14:56 +0100 From: Conor Dooley To: Ivaylo Dimitrov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Linus Walleij , Bartosz Golaszewski , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 1/4] dt-bindings: phy: motorola,cpcap-usb: add chrg_det interrupt Message-ID: <20260706-visitor-calorie-b805ac5af970@spud> References: <20260705101105.1798069-1-ivo.g.dimitrov.75@gmail.com> <20260705101105.1798069-2-ivo.g.dimitrov.75@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EHPotJN9Y/7sp6ZZ" Content-Disposition: inline In-Reply-To: <20260705101105.1798069-2-ivo.g.dimitrov.75@gmail.com> --EHPotJN9Y/7sp6ZZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 05, 2026 at 01:11:02PM +0300, Ivaylo Dimitrov wrote: > The CPCAP USB PHY driver uses the CPCAP charger detection interrupt > for DCP detection. This is not currently true, the driver does not look for this interrupt at the time of this patch. > Update the binding and example DTS to use the corresponding > "chrg_det" interrupt name. Sounds to me like this new interrupt is optional, since until now it has not been needed? The patch however makes it mandatory. I think your driver patch also makes it mandatory, which will break older devicetrees. What makes this ABI break okay? Thanks, Conor. >=20 > Signed-off-by: Ivaylo Dimitrov > --- > .../devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy= =2Eyaml b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml > index 0febd04a61f4..523a8f8480d0 100644 > --- a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml > @@ -30,6 +30,7 @@ properties: > - description: se1 interrupt > - description: dm interrupt > - description: dp interrupt > + - description: charger detection interrupt > =20 > interrupt-names: > description: Interrupt names > @@ -43,6 +44,7 @@ properties: > - const: se1 > - const: dm > - const: dp > + - const: chrg_det > =20 > io-channels: > description: IIO ADC channels used by the USB PHY > @@ -91,10 +93,10 @@ examples: > interrupts-extended =3D < > &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0 > &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0 > - &cpcap 48 1 > + &cpcap 48 1 &cpcap 13 0 > >; > interrupt-names =3D "id_ground", "id_float", "se0conn", "vbusvld= ", > - "sessvld", "sessend", "se1", "dm", "dp"; > + "sessvld", "sessend", "se1", "dm", "dp", "chrg= _det"; > io-channels =3D <&cpcap_adc 2>, <&cpcap_adc 7>; > io-channel-names =3D "vbus", "id"; > vusb-supply =3D <&vusb>; > --=20 > 2.39.5 >=20 --EHPotJN9Y/7sp6ZZ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCakvikAAKCRB4tDGHoIJi 0v+aAP9LtdSSmr/h68scZGIFlgV6ysH5j3UmXqH1E2gDLiQUNwEA3nVaHeU2gU7A 6DvEFs8Okg6Y6JMPXLUM2uDUSeiDOwY= =kZwB -----END PGP SIGNATURE----- --EHPotJN9Y/7sp6ZZ--