Re: [PATCH v3 1/3] dt-bindings: display: Add Solomon SSD1351 OLED controller

[Amit Barzilai <amit.barzilai22@gmail.com>]

>>     Assisted-by: Claude:claude-opus-4-8
>
> [Severity: Low]
> This isn't a bug, but this Git trailer does not follow the standard format
> `Tag: Full Name <email@address.tld>`. Without an email address enclosed in
> angle brackets, this will likely trigger checkpatch warnings.

This is a standard Assisted-by tag, see Documentation/process/coding-assistants.rst
for basis.

>> +allOf:
>> +  - $ref: solomon,ssd-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - solomon,ssd1351
>
> [Severity: Low]
> Should there be default values defined for `solomon,width` and
> `solomon,height` in this block? 
> 
> Since the common schema `solomon,ssd-common.yaml` indicates these defaults
> are controller-dependent, omitting them here leaves the hardware's default
> resolution undocumented in this schema.

These defaults were present in v1 and were dropped for v2 following
Krzysztof's review: this binding has a single compatible, so the hardware
default (128x128) is deducible from the compatible itself and does not
need to be restated in the schema. The driver applies that default when
the properties are absent, and the properties remain available through
solomon,ssd-common.yaml for modules that wire a smaller panel.

Keeping them out, per that earlier feedback.