Re: [PATCH 1/4] dt-bindings: clock: qcom: Add video clock controller on Nord SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new compatible string `qcom,nord-videocc` is added to the top-level `compatible` enum but is omitted from the `if-then` conditional block that enforces the `required-opps` property.
--

commit 3e90aae8332184ade41937f239c5a380bf14e445
Author: Taniya Das <taniya.das@oss.qualcomm.com>

dt-bindings: clock: qcom: Add video clock controller on Nord SoC
    
Add compatible string for Nord video clock controller and the bindings
for Nord Qualcomm SoC.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index 5d77029bfaf88..9b9878e9b9cfc 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
[ ... ]
> @@ -27,6 +28,7 @@ properties:
>      enum:
>        - qcom,glymur-videocc
>        - qcom,kaanapali-videocc
> +      - qcom,nord-videocc
>        - qcom,sm8450-videocc
>        - qcom,sm8475-videocc
>        - qcom,sm8550-videocc

[Severity: Medium]
Does qcom,nord-videocc also require the required-opps property like the other
compatible strings in this binding?

If so, is it a regression that this new compatible string was omitted from
the allOf conditional block that enforces it?

For instance, the existing conditional block enforces required-opps for the
other devices:

allOf:
  - $ref: qcom,gcc.yaml#
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,glymur-videocc
              - qcom,kaanapali-videocc
              - qcom,sm8450-videocc
              - qcom,sm8550-videocc
              - qcom,sm8750-videocc
              - qcom,x1p42100-videocc
    then:
      required:
        - required-opps

Without updating this block, does this allow device trees missing
required-opps for qcom,nord-videocc to pass schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-nord_videocc_camcc-v1-0-bae3be9e9770@oss.qualcomm.com?part=1