Re: [PATCH v2 09/15] arm64: dts: freescale: imx8mn-var-som: enable FlexSPI interface

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The FlexSPI controller is unconditionally enabled in the SOM dtsi but lacks a child node for the connected SPI flash device.
--

commit 636db0e489f17ce6e70d2d0ddbe2135a87fefaff
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: freescale: imx8mn-var-som: enable FlexSPI interface

This commit enables the FlexSPI controller on the VAR-SOM-MX8MN and adds
the corresponding pin multiplexing configuration.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> index 7a4c7455a1622..0bc9fb44069e1 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
[ ... ]
> @@ -176,6 +176,12 @@ ethphy: ethernet-phy@4 {
>  	};
>  };
>  
> +&flexspi {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_flexspi0>;
> +	status = "okay";
> +};

[Severity: Low]
Is it intentional to enable the FlexSPI controller unconditionally in the SOM
dtsi without defining a child node for a connected SPI flash device?

> +
>  &i2c1 {
>  	clock-frequency = <400000>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783330236.git.stefano.r@variscite.com?part=9