Re: [PATCH v3 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree example uses an incorrect unit address `dai@16` for `reg = <PRIMARY_MI2S_RX>`, which will cause a `unit_address_vs_reg` compiler warning.
--

commit 34242d1a4dde8cbcb03c8b665b181f4cb4658671
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode

This commit extends the qcom,q6apm-lpass-dais device tree binding to
explicitly describe Digital Audio Interface (DAI) child nodes. It adds
#address-cells, #size-cells, and a dai@<id> pattern to document per-DAI
properties like the interface ID and associated clocks. This enables clock
line enablement from the platform side for codecs hardware wired to the SoC.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
> index 2fb95544db8b5..42d05334bd391 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml

[ ... ]

> @@ -29,7 +70,22 @@ unevaluatedProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/sound/qcom,q6afe.h>
> +
>      dais {
>          compatible = "qcom,q6apm-lpass-dais";
>          #sound-dai-cells = <1>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        dai@16 {
> +           reg = <PRIMARY_MI2S_RX>;

[Severity: Low]
Does this node name result in a unit_address_vs_reg warning during
make dt_binding_check?

Since PRIMARY_MI2S_RX evaluates to 16 in decimal (0x10 in hex) and unit
addresses in Device Tree node names are expected to be hexadecimal, should
this be named dai@10 instead of dai@16?

> +           clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1
> +                              LPASS_CLK_ATTRIBUTE_COUPLE_NO>,

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706132009.1496321-1-mohammad.rafi.shaik@oss.qualcomm.com?part=1