From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88A563DDAFA; Tue, 7 Jul 2026 16:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440927; cv=none; b=jMR9OhCJ/12mpVseWrX6u3GUNhSMiXPjM6HT7uYuMWGnd0T0JT7D7KG5SfVXYg846G7b9rslgtOeTGN3bPWAy3YKw9zYVimeoEIJhAXr6VPgyXwkk9XeiOxZtj2EsFucy8Rrw0yDTr8yH0sGtMBPOawbcX+0iLkGwm6mX3WdwUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440927; c=relaxed/simple; bh=Pc06K2SlUk5TraOO1/tPbU4hMOOHHM4Jhv+0aavFKpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rydYRO0/u7wYlVc9T3B8GUsg6c12MHUmKMbVp7y37VuHoVcD4vEY3snimGaj/aU8On5/FJ3PdRdBp+2mnoyBJoo4TgMBMF+7BRXGJnECpxfz//agBtsP2PiEbLVCRlMCqYCsPIyz2zm3WmzoA9ng6vsiK9lfxQP4+cQUqChQXT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mxeLlqQg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mxeLlqQg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52B0D1F000E9; Tue, 7 Jul 2026 16:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783440926; bh=F88R+S6rc7ozRNA3csjjQyY6uBLsx6oJBsOm6HnxlVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mxeLlqQgkUFmpcfOoqyQSFbZyVtpHEFjAMv8Nm8L+DzAf7ALh5doUFKHJjjVay6BR M4/Jt4bLqGyK+6fpOiy2DIayCTAmloBFpa0p2CJccTOPcY0exHeKYeNyQaMrXG93M4 3P30RhjZGXrcE3ajE+HtEbsAczQqCu6cxVx/S41tKdZN67m5eAN8PoKhB5S59Wa9GR e426MmpdRW13uxgfp88ucE/UOH3j71g0Jn3UqdZuEYCtdH1s7PgFlA1V4NVrXxlP25 TD89gMVwe9Sg1OfNWvggUjVryIZ1pSKp/i7XlsUBIxNZ+b2Pc8PR3xuBF4MeabSCzu pU076qe6GVx7A== Date: Tue, 7 Jul 2026 17:15:22 +0100 From: Conor Dooley To: sashiko-reviews@lists.linux.dev Cc: Claudiu Beznea , Marc Kleine-Budde , robh@kernel.org, conor+dt@kernel.org, Oleksij Rempel , Vincent Mailhol , linux-can@vger.kernel.org, devicetree@vger.kernel.org, wsa+renesas@sang-engineering.com, Oliver Hartkopp Subject: Re: [PATCH 2/8] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC Message-ID: <20260707-hypnotist-portly-46b580fb922f@spud> References: <20260707102418.1646159-1-claudiu.beznea+renesas@tuxon.dev> <20260707102418.1646159-3-claudiu.beznea+renesas@tuxon.dev> <20260707103040.021DE1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eeSkgMZVqTITsw8c" Content-Disposition: inline In-Reply-To: <20260707103040.021DE1F000E9@smtp.kernel.org> --eeSkgMZVqTITsw8c Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 07, 2026 at 10:30:39AM +0000, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issu= e(s) to consider: > - [Medium] The schema fails to forbid the `renesas,no-can-fd` and `renesa= s,fd-only` properties for the RZ/G3S (`renesas,r9a08g045-canfd`) SoC, allow= ing unsupported hardware configurations to pass schema validation. > -- >=20 > --- Patch [2]: [PATCH 2/8] dt-bindings: can: renesas,rcar-canfd: Document= RZ/G3S SoC --- > commit fc07d92ff1acfa102fb8f08fa8b6ff1a0537c592 > Author: Claudiu Beznea >=20 > dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC >=20 > This commit documents the CAN FD controller found on the Renesas RZ/G3S S= oC. > It updates the bindings since the RZ/G3S provides only two channels, supp= orts > only CAN FD operation, and does not require assigned-clocks properties. >=20 > > diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-can= fd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > index b9d9dd7a79676..f8b4d3dd54afc 100644 > > --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml >=20 > [ ... ] >=20 > > @@ -350,6 +352,17 @@ allOf: > > properties: > > reset-names: false > > =20 > > + - if: > > + properties: > > + compatible: > > + not: > > + contains: > > + const: renesas,r9a08g045-canfd > > + then: > > + required: > > + - assigned-clocks > > + - assigned-clock-rates > > + >=20 > [Severity: Medium] > Since the commit message states that the RZ/G3S supports only CAN FD oper= ation, > should the schema also explicitly forbid the renesas,no-can-fd and > renesas,fd-only properties for the renesas,r9a08g045-canfd compatible? >=20 > Without an if-then block restricting these properties to false, the schema > will incorrectly validate device trees that specify these unsupported mod= es. This looks like a reasonable request. pw-bot: changes-requested >=20 > > unevaluatedProperties: false > > =20 > > examples: >=20 > --=20 > Sashiko AI review =B7 https://sashiko.dev/#/patchset/20260707102418.16461= 59-1-claudiu.beznea+renesas@tuxon.dev?part=3D2 --eeSkgMZVqTITsw8c Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCak0mGQAKCRB4tDGHoIJi 0smlAP9UYunv9LVF33FRMLSiU4bEBUtL6EvRW2JTroFv3tLtCAEA6h+w8g1PiuZU ghWJyI2ucpzNdWcEz6s7IlGuVON7SQU= =119l -----END PGP SIGNATURE----- --eeSkgMZVqTITsw8c--