From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C189743D518 for ; Tue, 7 Jul 2026 17:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783443987; cv=none; b=beisGWAADdq4eAA2lBSDL3HAufDFAcnlTk/A0Wpig+uN9GJGBiPYOgkLlQE1XsvDMWNY81jsm6khx+zfQLPat/fEcm5AsdqOnuCPnH3XodcEtOM0ljftHW5OaDD/fgMG3Jzb/5x1yUUhWJI43cNCwD/j5vhmN5VJnZrK2yy2VqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783443987; c=relaxed/simple; bh=R2ZYgPq+z9kQOw9KXl0c5XFfjclw4AYkbMjGsY2Asjs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U4XPSvwemX9wO2j64nWwcNnorVZwpLwNFXsXd2uUhkkUbAJVOaNc/NjTqTH0As5FuRpXUUYVe68QCtOeX/nlcVvK9lIii+I7mS/QWQnEMjeAHT5Vhyjix90hrMKNBWlflDMPEEPjDUNLlp0AQh0MLrgB7AdzAQIjltlnSNIWNkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=IeaOzMNq; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="IeaOzMNq" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-493bfe9f886so24487625e9.0 for ; Tue, 07 Jul 2026 10:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1783443983; x=1784048783; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ueiE0h6EH4y87IMMPnR7H3cpNk1yU2lRb2045uoET4I=; b=IeaOzMNqBHgcP9FKar94shR9RtumeTYEBfSEU00J/bQ8K7MrwnJTIIzPexPMrjIT9h zO7UxrUMM039O0z9Lk+WH7WKjVPOwCA56tSf8XgnrxMqo7g3KSB1kPwHSC9rFhkcQelH 8X9a+vmXXaymZJkBrF9vpfXVjA8Op+rbEtTVv3y+7S2eJIwu6FEm9kgqOGj8tH00Sl6C rRcsI1H9YWzcGGgms7yygFjhL3Ot+Ef4b3eVyfClhKWw79y1k8pBcDyXdOuGeaOJIg22 FRv7f+d2FdBYR9qbRY0ade5AVOfaRUq9LkChmXORShrxKGAEOJue6pPMsmp55yD1Z1Th z2fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783443983; x=1784048783; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ueiE0h6EH4y87IMMPnR7H3cpNk1yU2lRb2045uoET4I=; b=fx7+rjYkfJbPIJbzHhYG/LlKLV2fZwZiIjd/AlPSPU/mdHKifY7R3H7Thz6T6f/2Va yVUBtVlfbE0OMY3MdDV8tQqIMXQ7trl6hhD4uNekA7SOwhuv7Rw5rElRmf9iMWFXAFyk kLfYRDm/nVR6h1fR+ylhy+mCp1Id6Dk2dq3C4kMl3ohD4bD4Ai8SOuxQaLMzfXFaYaXZ /CBqrlA+mtVC345w4/Uy8d3tt6lP1ehXfHRJ/5C9eTdOXAE6B9qf7ZdkjGAiEc8ckr7C hm928SAcycoo8YetsGEEuZHApd+MtHbqDF16oYPj5ARpPv2MIuw48DxGnb1gQ7d2FF+R 1WKw== X-Forwarded-Encrypted: i=1; AHgh+Rqz7YuT7O39MCltZ8LOQo4XcVpbXf0ki10QEAacUVGSqTXVaUqPZ40Lmdk2XETHRBU9jRTb1MYZEYTv@vger.kernel.org X-Gm-Message-State: AOJu0YzomMlh3xTPKPEawDrhoBwCO8Rkl3in+TML1rurIljMNJBei9Tz 5AGuADLPwdHGniyv4iJXW/5BzvToOkjeUgJrLfFichitCpQszNQNyT/EfCo+zfE0Ue4= X-Gm-Gg: AfdE7cl8coCmCB2b957v7Rq2Vl0HMma+7GjK6inz8M0g7E9FFkn6tx1qWY7ebfyS31p f5An6ER375cmbqrY/rpc0zoH1G/886KMdX4Ge/R68ngKFAPw4d+X2K289sB5NQJjm6H9/P+JJni C6Sh99LcaIKP0BSPXk61girsSGxCAdcTrh/4Ng70WwlVz/TILzOKA1F5NEpImDZYCdGkJ8jBKaa qJZvN/lA7d7BwAyx5e69dfmm9pGW0F4iWxOvxyZ7h5LLGDNcG/I19NogM5T1CJnmZBD3omva7aX D9fy4U6ep8nI/8aFBzFoYX9vq/WP9+RvEitLzrRWRL9y/gdmcFRKsp0PpT2h6J9zZLU20znSFgG 2BrjAl0wpygtSoe5xphaFCPhkJH2dJ1vtV/A2PVV5lcjMxWIPL477tSYZbzWSHdZQoih0Kn4EDo L9cZZW2/S9j+hG9wfBdL5GhKs2yppWqUCmEUrSCcz3jG949JkUvIujlov8IsEg6uJC X-Received: by 2002:a05:600c:34c9:b0:493:e49e:f58 with SMTP id 5b1f17b1804b1-493e49e0f82mr15109475e9.4.1783443982938; Tue, 07 Jul 2026 10:06:22 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47aa0f21543sm33644487f8f.35.2026.07.07.10.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 10:06:22 -0700 (PDT) From: Dave Stevenson Date: Tue, 07 Jul 2026 18:04:41 +0100 Subject: [PATCH v2 09/20] media: imx355: pixel_rate never changes, so don't recompute Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260707-media-imx355-v2-9-1683ec07b897@raspberrypi.com> References: <20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com> In-Reply-To: <20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com> To: Tianshu Qiu , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Acayan Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg , Jacopo Mondi , devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 The pixel rate is always the same, so there is no need to try and recompute it in imx355_set_pad_format, and then no need to have the pointer to it stored. Reviewed-by: Jacopo Mondi Signed-off-by: Dave Stevenson --- drivers/media/i2c/imx355.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index 20cf6afee43e..9d977bac23b6 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -151,7 +151,6 @@ struct imx355 { struct v4l2_ctrl_handler ctrl_handler; /* V4L2 Controls */ struct v4l2_ctrl *link_freq; - struct v4l2_ctrl *pixel_rate; struct v4l2_ctrl *vblank; struct v4l2_ctrl *hblank; struct v4l2_ctrl *exposure; @@ -866,7 +865,6 @@ imx355_set_pad_format(struct v4l2_subdev *sd, s32 vblank_def; s32 vblank_min; s64 h_blank; - u64 pixel_rate; u32 height; mutex_lock(&imx355->mutex); @@ -887,9 +885,6 @@ imx355_set_pad_format(struct v4l2_subdev *sd, *framefmt = fmt->format; } else { imx355->cur_mode = mode; - pixel_rate = IMX355_LINK_FREQ_DEFAULT * 2 * 4; - do_div(pixel_rate, 10); - __v4l2_ctrl_s_ctrl_int64(imx355->pixel_rate, pixel_rate); /* Update limits and set FPS to default */ height = imx355->cur_mode->height; vblank_def = imx355->cur_mode->fll_def - height; @@ -1180,9 +1175,8 @@ static int imx355_init_controls(struct imx355 *imx355) pixel_rate = IMX355_LINK_FREQ_DEFAULT * 2 * 4; do_div(pixel_rate, 10); /* By default, PIXEL_RATE is read only */ - imx355->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, - V4L2_CID_PIXEL_RATE, pixel_rate, - pixel_rate, 1, pixel_rate); + v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, V4L2_CID_PIXEL_RATE, + pixel_rate, pixel_rate, 1, pixel_rate); /* Initialize vblank/hblank/exposure parameters based on current mode */ mode = imx355->cur_mode; -- 2.34.1