Re: [PATCH 1/2] arm64: dts: qcom: kaanapali-mtp: Add PMIC Glink node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [High] The `usb-role-switch` property is omitted from the `&usb` DWC3 node, which breaks Type-C role switching integration with PMIC Glink.

Pre-existing issues:
- [Medium] Missing `mode-switch` property in the `&usb_dp_qmpphy` node breaks DisplayPort Alt Mode.
--

--- Patch [1]: [PATCH 1/2] arm64: dts: qcom: kaanapali-mtp: Add PMIC Glink node ---
commit 6286754ebf3e4661a8a09cc98412dbc73a006aac
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

arm64: dts: qcom: kaanapali-mtp: Add PMIC Glink node

Add PMIC Glink node on Kaanapali MTP Platform and add remote-endpoint
linkages to DWC3 controller and QMP phy respectively.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> index f9b5b5718b904..3e9d9fb008ebd 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts

[ ... ]

> @@ -1328,8 +1371,6 @@ &ufs_mem_phy {
>  };
>  
>  &usb {
> -	dr_mode = "peripheral";
> -
>  	status = "okay";
>  };

[Severity: High]
The patch removes peripheral mode to enable dual-role, but without the
usb-role-switch; property, will Type-C role switching function correctly?

When a Type-C cable is inserted, the PMIC GLINK UCSI driver uses
fwnode_connection_find_match() to find the remote role switch using the
"usb-role-switch" property.

Simultaneously, the DWC3 core driver (dwc3_drd_init()) requires this
property to register the role switch via usb_role_switch_register().

Without it, does DWC3 fall back to legacy OTG block logic, causing UCSI
to fail to find the switch?

[ ... ]

> @@ -1348,3 +1389,11 @@ &usb_dp_qmpphy {
>  
>  	status = "okay";
>  };
> +
> +&usb_dp_qmpphy_out {
> +	remote-endpoint = <&pmic_glink_ss_in>;
> +};

[Severity: Medium]
This isn't a bug introduced by this patch, but does the base &usb_dp_qmpphy
node in kaanapali.dtsi lack the mode-switch; property required for
DisplayPort Alt Mode?

The pmic_glink_altmode driver attempts to acquire the Type-C mux using
fwnode_typec_mux_get(), which traverses the OF-graph and strictly searches
the remote endpoint's parent for the "mode-switch" property:

usb_dp_qmpphy: phy@88e8000 {
        compatible = "qcom,kaanapali-qmp-usb3-dp-phy",
                     "qcom,sm8750-qmp-usb3-dp-phy";
        ...
        orientation-switch;

        status = "disabled";

Since the usb_dp_qmpphy node lacks this property, the lookup returns NULL.

Consequently, typec_mux_set() does nothing, and the QMP PHY is never
instructed to configure its pins for DP out. Should this be added so Alt
Mode works properly with these new endpoints?

> +
> +&usb_dwc3_hs {
> +	remote-endpoint = <&pmic_glink_hs_in>;
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-kaanapali-pmic-glink-v1-0-3f7d476672d9@oss.qualcomm.com?part=1