Re: [PATCH] dt-bindings: usb: Add Aspeed AST2700 DWC3 controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The AST2700 DWC3 binding lists `clocks` and `clock-names` as required properties but fails to explicitly define strict constraints for them in the `properties:` block, relying on a loose generic schema.
--

--- Patch [1]: [PATCH] dt-bindings: usb: Add Aspeed AST2700 DWC3 controller ---
commit e94cba741ea120f96563c784f28513d593ede326
Author: Ryan Chen <ryan_chen@aspeedtech.com>

dt-bindings: usb: Add Aspeed AST2700 DWC3 controller

This commit adds a new device tree binding for the Aspeed AST2700 DWC3
controller. It uses a dedicated YAML file that references the generic
snps,dwc3.yaml schema and adds SoC-specific constraints such as a
mandatory USB3 PHY.

> Because reg, clocks and clock-names are only defined indirectly through
> the $ref, they still appear in the required list, the same approach as
> apple,dwc3.yaml.

[Severity: Low]
This isn't a bug, but is this description of apple,dwc3.yaml accurate?

Looking at apple,dwc3.yaml, it explicitly overrides reg in its properties:
block to enforce strict bounds, rather than relying on an indirect
definition through the $ref.

> diff --git a/Documentation/devicetree/bindings/usb/aspeed,dwc3.yaml b/Documentation/devicetree/bindings/usb/aspeed,dwc3.yaml
> new file mode 100644
> index 0000000000000..976f80b87e24c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/aspeed,dwc3.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - const: aspeed,ast2700-xhci
> +      - const: snps,dwc3
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  phys:
> +    maxItems: 1
> +
> +  phy-names:
> +    const: usb3-phy

[Severity: Low]
Since clocks and clock-names are listed as required properties below, should
they be explicitly constrained here in the properties: block?

Without strict constraints defined here, device trees with an incorrect
number of clocks or invalid clock names for the AST2700 could silently pass
schema validation by falling back to the loosely defined generic schema in
snps,dwc3.yaml.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - resets
> +  - phys
> +  - phy-names

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-xhci-v1-1-b202b9b3274e@aspeedtech.com?part=1