Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Michal Simek" <michal.simek@amd.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: xilinx: Remove EDK/Ethernet references
Date: Tue, 07 Jul 2026 07:34:00 +0000	[thread overview]
Message-ID: <20260707073400.9A6A81F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <43b2cbe78468fdfaf849a44a7b68ecbae521e611.1783406609.git.michal.simek@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] An orphaned transitional sentence referring to a deleted section is left at the beginning of the file.
--

--- Patch [1]: [PATCH] dt-bindings: xilinx: Remove EDK/Ethernet references ---
commit 8e2d62721bc765ab6c15f7e5831230b0e1f9eb33
Author: Michal Simek <michal.simek@amd.com>

dt-bindings: xilinx: Remove EDK/Ethernet references

This commit removes outdated EDK toolchain descriptions and generic
Ethernet bindings from the Xilinx device tree documentation. The EDK
version 14.7 was the last release in 2013, making these descriptions
obsolete.

> diff --git a/Documentation/devicetree/bindings/xilinx.txt b/Documentation/devicetree/bindings/xilinx.txt
> index 0ee9de99b3aed..7e8ad67134b28 100644
> --- a/Documentation/devicetree/bindings/xilinx.txt
> +++ b/Documentation/devicetree/bindings/xilinx.txt
> @@ -1,91 +1,3 @@
> -   d) Xilinx IP cores
> -
[ ... ]
> -		xlnx,odd-parity = <0>;
> -		xlnx,use-parity = <0>;
> -	};
> -
>     That covers the general approach to binding xilinx IP cores into the
>     device tree.  The following are bindings for specific devices:

[Severity: Low]
Since the preceding "Xilinx IP cores" section was removed, does it make
sense to also remove this transitional sentence? Leaving it here makes it
the very first sentence in the document, which might be confusing for
readers since it refers to the deleted general approach.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/43b2cbe78468fdfaf849a44a7b68ecbae521e611.1783406609.git.michal.simek@amd.com?part=1

      reply	other threads:[~2026-07-07  7:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  6:43 [PATCH] dt-bindings: xilinx: Remove EDK/Ethernet references Michal Simek
2026-07-07  7:34 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707073400.9A6A81F00A3E@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox