Re: [PATCH] Revert "dt-bindings: i2c: Describe SA8255p"

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Reverting the `qcom,sa8255p-geni-i2c.yaml` binding completely removes strict validation for the SA8255p GENI I2C nodes, allowing invalid device trees to silently pass validation.
--

--- Patch [1]: [PATCH] Revert "dt-bindings: i2c: Describe SA8255p" ---
commit 372cd0ac425472b6963cd0afcbe473297a95844e
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

Revert "dt-bindings: i2c: Describe SA8255p"

This commit reverts the addition of the SA8255p GENI I2C binding, stating
that the compatible string is already defined in the geni-se-qup schema.

> diff --git a/Documentation/devicetree/bindings/i2c/qcom,sa8255p-geni-i2c.yaml b/Documentation/devicetree/bindings/i2c/qcom,sa8255p-geni-i2c.yaml
> deleted file mode 100644
> index a61e40b5cbc16..0000000000000
> --- a/Documentation/devicetree/bindings/i2c/qcom,sa8255p-geni-i2c.yaml
> +++ /dev/null
> @@ -1,64 +0,0 @@
> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: Qualcomm SA8255p QUP GENI I2C Controller

[Severity: Medium]
Does removing this dedicated schema drop strict validation for the SA8255p
GENI I2C nodes?

While the compatible string is listed in soc/qcom/qcom,sa8255p-geni-se-qup.yaml,
it appears that the wrapper schema defines additionalProperties: true for
the i2c@[0-9a-f]+$ child nodes.

The wrapper schema also lacks references to standard I2C constraints such as
/schemas/i2c/i2c-controller.yaml# and does not enforce required properties
like reg, interrupts, and power-domains.

Without this file, will device trees utilizing qcom,sa8255p-geni-i2c with
missing or invalid properties silently pass dt_binding_check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707080229.3795971-1-shengchao.guo@oss.qualcomm.com?part=1