Re: [PATCH 2/8] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema fails to forbid the `renesas,no-can-fd` and `renesas,fd-only` properties for the RZ/G3S (`renesas,r9a08g045-canfd`) SoC, allowing unsupported hardware configurations to pass schema validation.
--

--- Patch [2]: [PATCH 2/8] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC ---
commit fc07d92ff1acfa102fb8f08fa8b6ff1a0537c592
Author: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC

This commit documents the CAN FD controller found on the Renesas RZ/G3S SoC.
It updates the bindings since the RZ/G3S provides only two channels, supports
only CAN FD operation, and does not require assigned-clocks properties.

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index b9d9dd7a79676..f8b4d3dd54afc 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml

[ ... ]

> @@ -350,6 +352,17 @@ allOf:
>        properties:
>          reset-names: false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: renesas,r9a08g045-canfd
> +    then:
> +      required:
> +        - assigned-clocks
> +        - assigned-clock-rates
> +

[Severity: Medium]
Since the commit message states that the RZ/G3S supports only CAN FD operation,
should the schema also explicitly forbid the renesas,no-can-fd and
renesas,fd-only properties for the renesas,r9a08g045-canfd compatible?

Without an if-then block restricting these properties to false, the schema
will incorrectly validate device trees that specify these unsupported modes.

>  unevaluatedProperties: false
>  
>  examples:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707102418.1646159-1-claudiu.beznea+renesas@tuxon.dev?part=2