From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C987442253D for ; Tue, 7 Jul 2026 14:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434845; cv=none; b=KTFhVEeYjmcRfzxJymAPcetXs6y/oCzt8ProuJIMM8n4yn+tnM7isAbmBSqlzdvQpjp6P836dIzCz4rzldQnnlKuFB0EmaD7DK4Zz9nmzTzOZKqUsg9ims1nRKVtXJ9QFLebGu+ui7+8hviHu+TM7Kz1gM+DCkowAoGnej+ZNBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434845; c=relaxed/simple; bh=FXW0ZQAR/HjOPW3bCqIDtjmq7ejZgfxyURrdwS0AZ3M=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Ksd746SmUcx9Jnt1jq06Dgj7sbDJgBpTv6UtSeGCVQAioe1+fV8gPMQrvKviQFOspky8uEdY6wbhJqDshDkz0aBNwwzFopRs4cfHFdK33mu8xrlF9FtC47Rs1aW+Ilzb6KllaKv7jt2tbgU6JDyVI14gGuMSjFjKWbgIPQ2+kU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PCS4s/rT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PCS4s/rT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA05D1F000E9; Tue, 7 Jul 2026 14:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434844; bh=qPPLFALCz8NXXZOTdxsis98fvVnKcnAHTN9imvn7xk4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PCS4s/rTRQ+a8cNa8Nteawau5Lr+JrTiaM6VmA88+sza4mEnr1QJGnfYGiHoQvNWr LU51Brvxvoh9zmgdQw+SU7m+PRVfHAn4EuSsTzZ6FEHwtO055ujhN3wM1F3cNgKEx7 8ZLN12/KQlG+2+gS4RJNAulBn+WWOPXUHK6icBi3QLlOzCX8mXqaDzDFKpXuKhsOKo moxUNqBitsqJYgEn63nmVCwJf8DRLXWq/kqOlnxti1pEbY+sj1crb/PIVN041vhhgd MeCjXrUWx4sKIthh4n3NpgnYkuieJP2EfWTIh0mBys/dqPPCyN7tR7KVi5fRBD0ron dyBGlB5B4IKKQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 06/12] phy: phy-mtk-dp: Support set_lanes in configure and properly cleanup Reply-To: sashiko-reviews@lists.linux.dev To: "AngeloGioacchino Del Regno" Cc: olteanv@gmail.com, robh@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260707141931.191172-7-angelogioacchino.delregno@collabora.com> References: <20260707141931.191172-1-angelogioacchino.delregno@collabora.com> <20260707141931.191172-7-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 07 Jul 2026 14:34:03 +0000 Message-Id: <20260707143403.EA05D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Missing NULL check on device_get_match_data() result leads to pote= ntial NULL pointer dereference. - [Low] Undeclared variable 'ret' causes a build failure. -- --- Patch [6]: [PATCH v2 06/12] phy: phy-mtk-dp: Support set_lanes in confi= gure and properly cleanup --- commit 564fc9b179c0513c9ad23d3689aaf0c8211c61c3 Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Support set_lanes in configure and properly cleanup Add support for enabling a specifically requested number of lanes in the .configure() callback and disable all lanes in power off and reset callbacks for proper hardware cleanup. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > +static int mtk_dp_phy_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + struct phy_provider *provider; > + struct mtk_dp_phy *dp_phy; > + void __iomem *base; > + struct phy *phy; > + > + dp_phy =3D devm_kzalloc(dev, sizeof(*dp_phy), GFP_KERNEL); > + if (!dp_phy) > + return -ENOMEM; > + > + dp_phy->dev =3D dev; > + > + /* If there's no devicetree, go for legacy pdev probe */ > + if (!dev->of_node) > + return mtk_dp_phy_legacy_probe(pdev, dp_phy); > + > + base =3D devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + dp_phy->regmap =3D devm_regmap_init_mmio(dev, base, &mtk_dp_phy_regmap_= cfg); > + if (IS_ERR(dp_phy->regmap)) > + return PTR_ERR(dp_phy->regmap); > + > + dp_phy->pdata =3D device_get_match_data(dev); > + > + phy =3D devm_phy_create(dev, NULL, &mtk_dp_phy_dev_ops); [Severity: High] Can dp_phy->pdata be NULL here if the driver is bound manually? If a user writes the driver name to 'driver_override' in sysfs for an unrelated platform device, device_get_match_data() will return NULL since the compatible string won't match. The probe will succeed, but subsequent PHY framework calls to .init or .configure will unconditionally dereference dp_phy->pdata, which could lead to a kernel panic. Would it be safer to verify the result of device_get_match_data() before proceeding? > + if (IS_ERR(phy)) > + return dev_err_probe(dev, PTR_ERR(phy), > + "Failed to create DP PHY\n"); > + > + phy_set_drvdata(phy, dp_phy); > + > + provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + if (IS_ERR(provider)) > + return PTR_ERR(provider); > + > + ret =3D devm_pm_runtime_enable(dev); [Severity: Low] Is the variable 'ret' missing a declaration in this function? It appears 'ret' is assigned and checked here, but it wasn't declared in the variable block at the start of mtk_dp_phy_probe(), which will cause a build failure. > + if (ret) > + return ret; > + > + return 0; > +} --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260707141931.1911= 72-1-angelogioacchino.delregno@collabora.com?part=3D6