Re: [PATCH 2/2] clk: qcom: Add support for videocc driver on Qualcomm Maili SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] CLK_MAILI_VIDEOCC incorrectly selects CLK_HAWI_GCC instead of a Maili-specific GCC or its underlying dependencies.
--

--- Patch [2]: [PATCH 2/2] clk: qcom: Add support for videocc driver on Qualcomm Maili SoC ---
commit d724606f8f1c3ef24540393df8039a38c743824d
Author: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

clk: qcom: Add support for videocc driver on Qualcomm Maili SoC

This commit adds support for the Qualcomm Maili video clock controller
driver, allowing video clients to request videocc clocks.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 6fd4aac1b6cf1..0409a2e604b0c 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig

[ ... ]

> @@ -156,6 +156,16 @@ config CLK_KAANAPALI_VIDEOCC
>  	  Say Y if you want to support video devices and functionality such as
>  	  video encode/decode.
>  
> +config CLK_MAILI_VIDEOCC
> +	tristate "Maili Video Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
> +	select CLK_HAWI_GCC

[Severity: Low]
Is this select intentional, or could this be a copy-paste error? It
appears CLK_MAILI_VIDEOCC is selecting the Hawi Global Clock Controller
instead of a Maili-specific GCC or its underlying dependencies.

> +	default m if ARCH_QCOM
> +	help
> +	  Support for the video clock controller on Maili devices.
> +	  Say Y if you want to support video devices and functionality such as
> +	  video encode/decode.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-maili_videocc-v1-0-ef0828c0bf6e@oss.qualcomm.com?part=2