Re: [PATCH] dt-bindings: iommu: ti,omap-iommu: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `ti,syscon-mmuconfig` property allows an unbounded number of phandle-args pairs instead of exactly one pair.
- [Low] The default value for `ti,#tlb-entries` was lost during the text-to-YAML conversion.
--

--- Patch [1]: [PATCH] dt-bindings: iommu: ti,omap-iommu: Convert to DT schema ---
commit 2b3347ad9c4854330b15c49c45269b76eeec7cd3
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: iommu: ti,omap-iommu: Convert to DT schema

Convert Texas Instruments OMAP2+ IOMMU from text to DT schema. Make the
'ti,hwmods' property optional and mark it deprecated as it is no longer
used, it is kept to support legacy dtbs.

> diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.yaml b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.yaml
> new file mode 100644
> index 0000000000000..c23156b9b3126
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iommu/ti,omap-iommu.yaml
> @@ -0,0 +1,112 @@

[ ... ]

> +  '#iommu-cells':
> +    const: 0
> +
> +  ti,#tlb-entries:
> +    description: Number of entries in the translation look-aside buffer.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [8, 32]

[Severity: Low]
The original text binding stated "(default: 32)" for this property. Should we
add `default: 32` here to preserve that information in the schema?

> +
> +  ti,iommu-bus-err-back:
> +    description:
> +      Indicates the IOMMU instance supports throwing back a bus error response
> +      on MMU faults.
> +    type: boolean
> +
> +  ti,syscon-mmuconfig:
> +    description:
> +      Pair of the phandle to the DSP_SYSTEM syscon node that
> +      contains the additional control register for enabling the MMU, and the
> +      MMU instance number (0-indexed) within the sub-system. The instance number
> +      should be 0 for DSP MDMA MMUs and 1 for DSP EDMA MMUs.
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      items:
> +        - description: phandle to the DSP_SYSTEM syscon node
> +        - description: MMU instance number
> +          enum: [0, 1]

[Severity: Low]
Does this schema allow an unbounded number of phandle-args pairs?

Without a `maxItems: 1` constraint on the outer property (or using a list
constraint for the outer `items`), could a device tree with multiple pairs
(e.g., `<&sys1 0>, <&sys2 1>`) silently pass validation even though the text
binding implies only a single pair is expected?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-ti-omap-iommu-v1-1-48cfc53aaa46@gmail.com?part=1