From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EA4399369 for ; Tue, 7 Jul 2026 22:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783463370; cv=none; b=Bl8v8uZ/ShXcuu+zNB8WpvT+QklVImiQxNWCwQGs3ntDFS02xc5rogU/tjMrt2rcj4+y4/OPkF2zymnOqA2wyCiTjE3HK+MRwGqhxuFxyDVl85YSrXxvOqyBmyy5VFAsAE+Abbhc6N5ggCFh6/D8EkkAVL2fPkaOCvDkscKNJzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783463370; c=relaxed/simple; bh=SUPr9326R8/I85NqmtSxzGXasITRZ38mBZxBYOCk/p0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E/Q1Q2dxnxknCcRFZ+SCwOBxI5iewy2/n3u9OmWqfzlXDXYXzKxQ0B9EdueoVDs5ZEX5o3MoHZzGE06z/9S2qChdtKxs1T4c5C3ncAABejU1hq7wFaCrl1Oti5ykcbTS0qG8KWJ1BRSr7KGTL06cdddmkYoec7qnDCv3HgZfOZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X2n09zQP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BnoukAi7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X2n09zQP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BnoukAi7" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667J5RZ5490954 for ; Tue, 7 Jul 2026 22:29:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rZBfUegtVT46gf+3kV/ulvsSL+G4ssvBArwyOeiJ5Vw=; b=X2n09zQPwL9gWXE9 OD90iq538Jgsj4lUECmkVF1aKfmz+JbJhTHUs7vI1uVAGAwoHGMwDPiEFF5uaoMD PDsPT+KORlTPY0Kv8L0vfMBXtu0Rj/Y4RA3AFOISHTYQqhdXXthjCZMQY/1PAY4b zflDjRro7JDaA3VX0adxfY3Wv0ReapJ5lxb6qW80t/bf8OGGSALxFYwLm+itS5vb 0vgVFqV2C+T11QjDrwa5G5KQa6akB+z+y4skshgOmaOJS287vxEfg/E5i1UZN69V bFuM5LqQ8DHC8dtKpmzclxH74g6XCbvFFsNKR++LOufaS3DETanx5LVY5QBZTVQe sFdsrQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8v9ac2sc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 22:29:27 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-73c040cc990so8315137.0 for ; Tue, 07 Jul 2026 15:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783463367; x=1784068167; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rZBfUegtVT46gf+3kV/ulvsSL+G4ssvBArwyOeiJ5Vw=; b=BnoukAi79nDp9IhIC1nJ6S+BlycjQI9DiWFduVY18qjxpLBiDkBsdNjo24G6JkY6O3 Laqci6CxsQZOvRmPkz6knOf5cpbQbdbZ2OrUglMP5Wy5vdqN4AfRzany0XRJJGLoeYyh E2cwOIOMAYEjPJU2fpXBC3beNXLcg9+s3hlLffjlUo0jjRZYIfcT6wK9FaDSIKsPSrFt HWnvsYaGHmMb2kHQMB1B1mZ5nslrBar8NfvZrFUzSf+6gjRdQbBq8fEVXx4JkUSK17LP a/kubeph5m09vApiAKhpG+9diJdGnhvfwjdyu9R2dsmkTBhEo1nTJql0QePO+f7Aq5jw 1Jyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783463367; x=1784068167; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rZBfUegtVT46gf+3kV/ulvsSL+G4ssvBArwyOeiJ5Vw=; b=KrlCHYiz78UXU/9ixZHEOZGiGYFbi1ppc7la4XiDuvQWoFSjUZ+EN8uYScdjjIQCFf lhBIZJVCCos106mUp3eLSBGCytyhC/TtSH1lvBhp55Tksvek6AgwaWA2GQCT98MqLgxz UvGv97+2f5J0JTiXst+ukUYH1YbsUQ5XbEcu2becy7QJ3x/DmctoGBXgS+T7+HBmxcqM ONjMCZDjwjZFybnJg/TxGir2yg2Zg8mliqMI4DJlxcXbv4Op19cFMazMHdOQjfOAKTGE nnIkZVsyXZJOVFw46Du/BTVIip3MJKuw4DnjmTuh3kIdGe0Fnl5Czp1vR6foVjRRQRA2 +9sw== X-Forwarded-Encrypted: i=1; AHgh+Rru0L+vwofkTV61ZdQEoFMzI8taKIBxMzgiZc/RdrORcSON2qIj9I2o0u0g8C+VUwFiRJieJwUQD+ZA@vger.kernel.org X-Gm-Message-State: AOJu0YzU9WvSztBCXoLtAw8Ujo02qfTIIgmttWwqSe7wiob3DuzZd7sd wlm3Uqhrmy7E6pytcLVd8A2OqPbnfwAOALFpRdDdW+rALAQzj53jL1qWbO2nHK5yfp+fGdgSkAu GuSTszl9QgyD0AiLxm+fqMRSwhitYEIW3LL+poCLYNl4D/lW2TDaAp6na0eRbQsm8 X-Gm-Gg: AfdE7ckzu77w1jYtptpMfQwCiSkT6eBlEVGVadEhbsWYd5KtX+8vwiuQSD2kO8zAjkQ UvIRPcp74LvGwCeYnC/ex96vwAuozBnytMeYIRnDG/hfm+/reqMtwq5XuNE3PXaaXpvyiEhPQ3x 4qDYHWuYDwwOjwb2e0lBTsjzC3+0saqxDbs060GWOxkHhoBNWAJDf9x2AeAmAsKFjH1BufAmYbH RmCCAM5w9B54+hqNMNPMteUsOEGeVxpgAfAqDlT7VTs3GnDiiH6aNKGrIfFNEMjMqO/a7yjziUk fU6gkrL61ULckBg94pvxaFFBlIrpGBPO7t5AygY81qhwi6XqYh8a9DWThE4dgP36GlNGf/3qGlj TJEWaqfHYjBgjeFqGIAprEKc7t4JVRW0hIn0hp0M4ZpVDu57VVCduheapZdlo+RnNx2Q0/6bWWZ FVRVKsDQz+zdfnWVYhpUYVdj60 X-Received: by 2002:a05:6102:5691:b0:737:4cac:52f8 with SMTP id ada2fe7eead31-744b7b445e8mr3854115137.4.1783463366665; Tue, 07 Jul 2026 15:29:26 -0700 (PDT) X-Received: by 2002:a05:6102:5691:b0:737:4cac:52f8 with SMTP id ada2fe7eead31-744b7b445e8mr3854104137.4.1783463366204; Tue, 07 Jul 2026 15:29:26 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39c7312bc25sm1897231fa.40.2026.07.07.15.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 15:29:23 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 08 Jul 2026 01:28:48 +0300 Subject: [PATCH v6 05/18] media: iris: Introduce set_preset_register as a vpu_op Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260708-iris-ar50lt-v6-5-374f0a46c23b@oss.qualcomm.com> References: <20260708-iris-ar50lt-v6-0-374f0a46c23b@oss.qualcomm.com> In-Reply-To: <20260708-iris-ar50lt-v6-0-374f0a46c23b@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4447; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vk2n05YaqyNL1lA1l7CdzDHPMAEMMeRGvxRtE9L+Mhs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqTX2oPKN8drf4UqCJTHZ31bVuO1adnIfKPTA3x Cp1hcorwmmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCak19qAAKCRCLPIo+Aiko 1XvvCACQphdWIJgYuyX8RQLL7VNjFiLlJkvueBVcrBgf+9T3xQmKq+4dUhl/dm8XcXTKH/Bv44A W4vn1l3uR47KnvuCJ/5hp13kw259KvoOyA+j9eeNqPEqQLg0TmORio26TEdYJ/icI0OzvChWylf mM7BVXVDF06HgZkvVDBFnhBbaPgRhvu6EFhMyHBNlEf54WGLJMsznblIHZbOXfqliZwFvBBxTVm tamUPGoG9+QQ2V4N86tVHDOo+U899OwyHquqmq6/s5Ku0NixIcAx/PAPp0OAh0V+v5DCYiYn2nI ZCZ4YW1jDJiuOM2sINAJg/ZVk6R4eapw7lkc9TLhaU28JspE X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 8spQ7EauFisRpy5QRsK_clsEKckRsz90 X-Proofpoint-ORIG-GUID: 8spQ7EauFisRpy5QRsK_clsEKckRsz90 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDIyMSBTYWx0ZWRfX2TyJ6o3d5ERH fnNNYKaO1SOYAIvNC2BEdK6C3zdqOSzwXArdPkM7pWkgIqwTJoTlvFYDBhPUVpAgX6TR2/d/LfD SDNAKGuYNcHhsGadnczvfSAA7QEZi44= X-Authority-Analysis: v=2.4 cv=b9yCJNGx c=1 sm=1 tr=0 ts=6a4d7dc7 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=4Uh0hlRDs2lXuULb_e4A:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDIyMSBTYWx0ZWRfX17SA5wZ0DnnV K4791DQK3lpf0sdU9tuNLkI0uWASfxB+GEIJTR3iaDR2ZcHNjva70453jer9lEaf/85WZel9tkD Z67QyTHwQxf3ophW2Ub13rZgx7d3VnKkMFoer98G6tTyL7QYT5ClRZQZty0gCU/aJcZXqBRC1NP 2nG/DzoKGs//yMpaihwjte2ZFmgFSsfZWwTj5ljuQlLbcNj1t5mmOnQJ6sx2zFurEldirvE34EI IV+6FdkPfglfDgZsUJ7A/mo/sarLkarTE35jmRh1R/OxwBfXnOSI888Ro7IEmfC+b2ZPjnA1Sxm 8v1M02SDs/J2Td5H7jUOa9CQ8P4CjzwUlCR1UIl8z6qIj2aSFQSB2vo1xMogSDPpko+dB9eqhFX O+xfr0UZMYIzAN/yynt7QVvLbKhfzVBvUueTz86Yn1gufW1fUE22nihexG70J/edgNd8pkHq2rR e+YbVj9GoqF43APRrjQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_05,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070221 From: Dikshita Agarwal The set_preset_registers sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move set_preset_register into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vishnu Reddy Reviewed-by: Vikash Garodia Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- drivers/media/platform/qcom/iris/iris_vpu_common.h | 1 + 5 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index b8714dcbad10..2dc121a3f5e8 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -45,4 +45,5 @@ const struct vpu_ops iris_vpu2_ops = { .power_on_controller = iris_vpu_power_on_controller, .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index 3dad47be78b5..dc02ced1b931 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -261,6 +261,7 @@ const struct vpu_ops iris_vpu3_ops = { .power_on_controller = iris_vpu_power_on_controller, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; const struct vpu_ops iris_vpu33_ops = { @@ -270,6 +271,7 @@ const struct vpu_ops iris_vpu33_ops = { .power_on_controller = iris_vpu_power_on_controller, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; const struct vpu_ops iris_vpu35_ops = { @@ -280,4 +282,5 @@ const struct vpu_ops iris_vpu35_ops = { .program_bootup_registers = iris_vpu35_vpu4x_program_bootup_registers, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index 02e100a4045f..f608a297d4a3 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -368,4 +368,5 @@ const struct vpu_ops iris_vpu4x_ops = { .program_bootup_registers = iris_vpu35_vpu4x_program_bootup_registers, .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, + .set_preset_registers = iris_vpu_set_preset_registers, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index ab41da1f47c8..a49113b0da23 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -483,7 +483,7 @@ int iris_vpu_power_on(struct iris_core *core) iris_opp_set_rate(core->dev, freq); - iris_vpu_set_preset_registers(core); + core->iris_platform_data->vpu_ops->set_preset_registers(core); iris_vpu_interrupt_init(core); core->intr_status = 0; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 09799a375c14..21ed4c9bd5e3 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -22,6 +22,7 @@ struct vpu_ops { void (*program_bootup_registers)(struct iris_core *core); u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); + void (*set_preset_registers)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); -- 2.47.3