From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 453333E63BD for ; Tue, 7 Jul 2026 22:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783463374; cv=none; b=J+xc0IbS6cT3xpVbDmNRJpRT1hzkLSSIuDYULSMnCLLZLzs4YutLVbRaf+vsiSDPBaYyh9ZbrFI70PJMnsP1kRCDh9aDXG0Hl2uy31U/a3dVgVpqdbq99Bftv7402JJwHMtfApw1UZ52ExACLGpgtB+G+JGeUzN1OaLkODe1JLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783463374; c=relaxed/simple; bh=mn+e/RylLLe8OTePgCv2X/kFcuAkbIe3sFltrQBvOOg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NspXPOF55G4jZ7Lqdc6gDqxTN9QRczp7hgmRY5J1FNsqvGHbqtWrN+KSjA+iP+fEHPAjeZfFCQpxPvKJwzkuFgWZNv4lMxLzTeyJMMw/mY5hbpjiUbM4DWf1SJrqvYL/DKvLLqVHhjS7E8OCjUwk0gbCaEritTnaLuCfKvF4NlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WwY2ZF0Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HZbOICoM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WwY2ZF0Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HZbOICoM" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667J5DlL518084 for ; Tue, 7 Jul 2026 22:29:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=WwY2ZF0ZwrPiDpbq +FDDNdtyrKM2wYanMnzIYjpPDBXf+tJ1dsXcyT45c0YG//FMXglaPU/0KGrsxi87 3YfxjnYOWRet+Lqy+ZVG3cwFpGC/mVPvX/WHnqQ6H+misgMQkFQFOQ3Xb/ltypp9 NP60TYPZ1CMilAOnZT7v2oXrFLso2ftIPuprl1doAUDd731aZeGMOlvBuUgjE1Ay pkP3eUlg6M7lG5Q1GwOmjsAsO3tCl4N5tkMFJU7xmxyNcPOmutaSAaczKpevOuSq qOmAKf3KHJ5qUvInF3v0N1MIn3AWdr65EiHBDUdLqcJ4c6+BI23pEdtIPKE0yaLI SjYfNg== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f95e5sf6r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 22:29:31 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-9692ca167ddso25162241.2 for ; Tue, 07 Jul 2026 15:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783463371; x=1784068171; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=HZbOICoM0uU7qFJbYiMGJOfivvmdtb6eEAHjsE8jwaSB9J+a61xFhiB2X1zWfht5Yq LS7i650LHoU4B7VxVXtXFEM0I/hrrejWCua5xkxHHZ8Jh6giHQcvAfxdp1Muhot01kPQ Uw2n6feY3d1w3KJ+tCdhOreRcuw0fB2jzuaLAKz6Yo9+SGczD/B9aby36vQbjm5PxUI1 QR3J5+d+KF0h4ImgKN8fujv3iIiIwa3KxOV4EPmY4Is4OsoQ2uSzFY85SXUvazqlqHux J3zUZOclRqzgN1wVoUKnLjOrByhtI5y7VWRbbyzq7nK27Ub5LJCB8ui5e+taHCuEq+qW RvTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783463371; x=1784068171; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BSlDrwbGIU+LailKGlDSa67oRh8dtUgn/OIYCvnUjAg=; b=ZUVROvJwuDYDeH6M9/ca4Ir98H5OhXkV7hc9IzB+6jaQBdSF9Cxan+Bq6nolBxkvIJ gbnPMXFj50nDFcKHTtFq37KanzAkk+l/YzEhRkQGPlgARjZE7uOUPVccaV6lRPuzbcFE TXihxCB7gugPNxDHlt1ZE4A3yVG2RgeQxH61dFFk0ZCqBejOV2LbqZ+0gRQbdRFXmlF7 fTI8tFXNMjyS5J4oaX+GfqeoiB8unt4Y64/UAGVPgkFhFOcRXRbwoUsXNcefMxhEWTNM 4nqofq3+lXdai1Cv+j44TxX6Ggs3N4wxsQgwUeU5z7nuiKn66KKZ00Cg6VcvXn3IMWaX 666g== X-Forwarded-Encrypted: i=1; AHgh+RpsrzZ689Wb6eqX7nW2YKOTrvFVgduZ5QmuCRBOpcuj6Ou9bOYZRmVLnb2EPqKBqabt+RMW54a4KVPE@vger.kernel.org X-Gm-Message-State: AOJu0Yzc26HZIFhiHtuEFoWBzQU9QpqGDf5X0fFMxjdobvPy93eRuzPd pyQEKi3dQ0GphNrPAXQelg7BgIMHBIiXKs68TFn4GHXf6W0U6ZZr+6277NANa83IfsU1EmNqEij lcnfB1F95OCAoO7seB/FOhkWWRnd6X1o1F1so31XzQUZ5hHGrrtoe+Yna4RQTvxXT X-Gm-Gg: AfdE7cmC2kJ0ch1atTjLL/9maQcNGuR+I61+40x6QXDAiqhqF3cdX/etFG7LQ9bD11q cpS+jUjY1CLCSEIi9U9mI5K6IPicHoFtr29aB2SOmDeMABGbo48kGkPm4u35TKvNWnysj+VfC+Z Zjy4nuQI4GqBdKoJxrGXBwXAm58GwgQKk1S1XDfwfMAI+J4rHSNNH/1R25qLQl2waKXELG5OLat rmxt3WgLr+OUTrLZySBEu4MeEOsED1cID68Ks9qtSz/NZUVqXDEq2a49CLNomLu6G4W4+cPsu4+ hA3d/AECJPWWO86LfdyjC/pFz9nc6q4tcIHTE/1FX1tsNuoKCON+HBc0RUkHGUD7YGFikpDYikf HjtUgJIMtTuOxfKFVvNDyFrCpGIWkq00NbTWlKQjwXwE+82k6+kVXmNtdnQg2+WdrDNknVbcbz1 NEBGBr4rvlkg/105uGIEmOFo4G X-Received: by 2002:a05:6102:148e:b0:737:fce1:3277 with SMTP id ada2fe7eead31-744b7de56d8mr3946574137.26.1783463371164; Tue, 07 Jul 2026 15:29:31 -0700 (PDT) X-Received: by 2002:a05:6102:148e:b0:737:fce1:3277 with SMTP id ada2fe7eead31-744b7de56d8mr3946559137.26.1783463370665; Tue, 07 Jul 2026 15:29:30 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39c7312bc25sm1897231fa.40.2026.07.07.15.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 15:29:28 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 08 Jul 2026 01:28:49 +0300 Subject: [PATCH v6 06/18] media: iris: Introduce interrupt_init as a vpu_op Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260708-iris-ar50lt-v6-6-374f0a46c23b@oss.qualcomm.com> References: <20260708-iris-ar50lt-v6-0-374f0a46c23b@oss.qualcomm.com> In-Reply-To: <20260708-iris-ar50lt-v6-0-374f0a46c23b@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4931; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jlbWJ6BnLAb8hDHnLKbkTUpBs5ZGORWEUsmmVGvPwio=; b=owEBbAGT/pANAwAKAYs8ij4CKSjVAcsmYgBqTX2pwoX8RSP5D7/lr/H8aso+Rq1OUM4XYc9ef vhBiQ4CYVeJATIEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCak19qQAKCRCLPIo+Aiko 1R7NB/jZ5Q9TestWO2UwnumbeoAbma59S0SYWDnBw5DEqBV21ky+K+U6sV5YfehVsquxgPYEhXE wEA4O7WEI/2+r59KSk21VvvG81cOpDBABd3ZG3ntKJ1lEUEnFS/EPoYIqFxleaeDdb6Fko2qzd6 yf1IjwmxXiffeUXdDif+BK4qd9T8qyGUdHRINCpPJCdQfLBHijY5bVpI1KxXobdkSX1HHusUH6f hXY8Nwg96hYp3/sCcSq3hn7zpDnEwCVKqXIAjvBAeiHMJitTia+DEsbfxMS9ImEI5kbldIYMwHy feouNqXUc1Wi0GoWWXYQTk/8ifyW1HOcjVKYZADPdZ23KsE= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 85Kj7k5D1yl7iv_ozHZYhB_1DoXXKqut X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDIyMSBTYWx0ZWRfX9KtJAx3GhZCv 0NF5DT3nICVgfdbuqpgTQ6I+zQCSM1FMrPSe33pSHhr+tY6HqQYlmJCmQ+dLR4cB1WR2D07a6IO rxfnRYYjWyQWoc2h4kMMN1SpsWkHp0s= X-Authority-Analysis: v=2.4 cv=CNoamxrD c=1 sm=1 tr=0 ts=6a4d7dcc cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=2EYiHOum3YQmkHKk0wkA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-ORIG-GUID: 85Kj7k5D1yl7iv_ozHZYhB_1DoXXKqut X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDIyMSBTYWx0ZWRfX2v+KvwL+7ink dmCG/J+YOYQatn2IZjpaoELJnv9yECNRErgxwtWnFqVv56NTUcL2p6l++KNDitrBIOtGvZ0Qvg1 7Lare7JjCmhlMSzhm981g7+545W1n4CRwkhFgtas2EuxBXrm4YBJuSoMv3Op3q90MM4wiGNdFzo jD2qSJU66fQJqb+v2fd4wL+7Zhgcc+gebhkrVaKxb8JKy6c3zOihX95rEbuH/FRiKa6E9QNkkzO PJsSTWEuBFJtEAUgQQtQozDGWA5ROoQFCXRlwG6hCQhHVySiBCRt8A44fKyTir/4RDLXX130uJn 34Mt1MuDJFGyT8zjVLsDpia3aFsqsNJBdriA5FDB/M2hkozAzwIXFdGO9NSemepo63Znaiz0EBq IUgs+MilJOHcQQ7DxaoHs2HDzRe7YY0QFlm1u6FDIOc/aDQSl1wSet7kj6d643XfKIsz3PwQeng snRrOglJfiGwfp92VDQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_05,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070221 From: Dikshita Agarwal The interrupt_init sequence is currently shared across all supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register programming would differ. Move interrupt_init into a vpu_op to allow per-device customization. This change prepares the driver for upcoming hardware variants. No functional change so far for existing devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Dikshita Agarwal Reviewed-by: Vikash Garodia Reviewed-by: Vishnu Reddy Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + drivers/media/platform/qcom/iris/iris_vpu_common.c | 4 ++-- drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_vpu2.c b/drivers/media/platform/qcom/iris/iris_vpu2.c index 2dc121a3f5e8..dd2eeae0d9eb 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_vpu2.c @@ -46,4 +46,5 @@ const struct vpu_ops iris_vpu2_ops = { .calc_freq = iris_vpu2_calc_freq, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu3x.c b/drivers/media/platform/qcom/iris/iris_vpu3x.c index dc02ced1b931..c3b760730c98 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu3x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu3x.c @@ -262,6 +262,7 @@ const struct vpu_ops iris_vpu3_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu33_ops = { @@ -272,6 +273,7 @@ const struct vpu_ops iris_vpu33_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; const struct vpu_ops iris_vpu35_ops = { @@ -283,4 +285,5 @@ const struct vpu_ops iris_vpu35_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu4x.c b/drivers/media/platform/qcom/iris/iris_vpu4x.c index f608a297d4a3..90ccdc0d2a07 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu4x.c +++ b/drivers/media/platform/qcom/iris/iris_vpu4x.c @@ -369,4 +369,5 @@ const struct vpu_ops iris_vpu4x_ops = { .calc_freq = iris_vpu3x_vpu4x_calculate_frequency, .set_hwmode = iris_vpu4x_set_hwmode, .set_preset_registers = iris_vpu_set_preset_registers, + .interrupt_init = iris_vpu_interrupt_init, }; diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/media/platform/qcom/iris/iris_vpu_common.c index a49113b0da23..375bcd923476 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -31,7 +31,7 @@ #define UC_REGION_ADDR (CPU_CS_BASE_OFFS + 0x64) #define UC_REGION_SIZE (CPU_CS_BASE_OFFS + 0x68) -static void iris_vpu_interrupt_init(struct iris_core *core) +void iris_vpu_interrupt_init(struct iris_core *core) { u32 mask_val; @@ -485,7 +485,7 @@ int iris_vpu_power_on(struct iris_core *core) core->iris_platform_data->vpu_ops->set_preset_registers(core); - iris_vpu_interrupt_init(core); + core->iris_platform_data->vpu_ops->interrupt_init(core); core->intr_status = 0; enable_irq(core->irq); diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/media/platform/qcom/iris/iris_vpu_common.h index 21ed4c9bd5e3..9151545065cd 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -23,6 +23,7 @@ struct vpu_ops { u64 (*calc_freq)(struct iris_inst *inst, size_t data_size); int (*set_hwmode)(struct iris_core *core); void (*set_preset_registers)(struct iris_core *core); + void (*interrupt_init)(struct iris_core *core); }; int iris_vpu_boot_firmware(struct iris_core *core); @@ -44,5 +45,6 @@ void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t data_size); void iris_vpu_set_preset_registers(struct iris_core *core); +void iris_vpu_interrupt_init(struct iris_core *core); #endif -- 2.47.3