From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D03D846AEF0; Wed, 8 Jul 2026 12:55:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515347; cv=none; b=VS0xa2W67Fj/TbWM+FdFvkSJJ9mYB6snQPTaN26BkTtw/KOsBK9oGABJWF4Uqk8/LrnHsaD8KEiUhF35WYPqOcYmGfLvYcIVVX+ejMexqcW+mJB9w2WG3dS8RoPUUwWrB2u5F5AdK584vuR5C3VcpnqjkUIrRhUnJn6CfK29zo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515347; c=relaxed/simple; bh=hijVYe8KxEVoZNJtjyTvlZhg6LtGK/9oDMwFLXJW5kE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GuWQzzhIQ5iIHWMH0fULFFHOmfcvjkKUB4BeUACsRCBBNsA1lki2pxIBWLxjSqOvhCBlqVpsfCccBEV85a0O0mJYQrvTvCwGe8z5qTxd5Jvx/h8fWQ95ng73ucwnCw4uRSHRX6p/yBuJ4rmOdHMvMGemeuufLgogff6YmQT1mbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cCME3GIm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cCME3GIm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA401F000E9; Wed, 8 Jul 2026 12:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783515345; bh=ekw3kGoulztvJqYJOHlKxlq1g6XBqAFca+u/fGYqTGM=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=cCME3GImwh+HKcbgbIM5xG6cQqKKPJ5Q2dxdxIPLaKxBlAAj4hva+p+TvOJzVzGpO Dq/0EcgfRV1mtG9gfkKXG3+2A2GsSORKSMBXjzTjFeU55nSectodQEwnUCOiyLhji2 DICKlKP1YVf4YLZ+zllFN3RknlOOx8Ae7iUJMoVO5E4LE/mXfij5+5s1H2wDilgncE O1tcJYbbsTjnZHfJw3bZftNHnlWkLOxpesz/Nfxrk3M8QxeZ7boCg9/zGQT7nf/zQk 8BjVKFulP4Ny9w+zyWnrHbBY8pHVym2Fbo4shOG5R9UGaSNMmZ0aO5khOxtuYAXTC7 z8/c7gxfEEPTQ== From: Mattijs Korpershoek Date: Wed, 08 Jul 2026 14:54:21 +0200 Subject: [PATCH 2/2] phy: qcom: qmp-usb: Add support for SA8255P Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260708-phy-qcom-qmp-usb-8255-v1-2-8d852a9535db@kernel.org> References: <20260708-phy-qcom-qmp-usb-8255-v1-0-8d852a9535db@kernel.org> In-Reply-To: <20260708-phy-qcom-qmp-usb-8255-v1-0-8d852a9535db@kernel.org> To: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Maxime Ripard , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , Sriram Dash , Shazad Hussain X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=9501; i=mkorpershoek@kernel.org; h=from:subject:message-id; bh=64/Kor6kEuHXf99/zr/pzWO7bKPLdKa6A7+PUWz998g=; b=owEBbQGS/pANAwAKARkNHbRmThk1AcsmYgBqTkjILKqjSkXuFXDrzM0iRJVm0iVzBOSD2ZLPK vMS+VBHYV6JATMEAAEKAB0WIQQu6UKnth9qvlMTrQAZDR20Zk4ZNQUCak5IyAAKCRAZDR20Zk4Z NW2ZCACLUneSyI5g1xaE5NmCHm6mMLW3E7LU9OAtvMvgME1QskO4OlUvB+Z3cKDnHrog9EGSpPZ g5AD+ACZGni/xrAN5g4zVp4GuApBnZKQCaLX3layKnKYd9u2ZPW2tg2DdC1UgFDQciV3wxbPXdW 8BuvI4gfXLT9kXiCOdHazcUIXzLVW98Yj+KRdY3cgQ/94ta4sFfQVhi3/mPmqTLqIs6l4GsuOUr LrLSKki+8WwcgSDZJ9k8G6Iy/W8t65fAf0lizXvGpDp30fvoC6ukXPSmZ7f+XtQo0A8c/ex4mVm HGw5A0BeGUMFKXWySluG2UChyPWUBF8K1HO7w0uIYLD1IIWZ X-Developer-Key: i=mkorpershoek@kernel.org; a=openpgp; fpr=8234A35B45C0D26B31C1A2DA570338B018144F28 From: Sriram Dash The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GPIOs) using runtime PM framework APIs, such as resume/suspend, to control power on/off. Power domain "usb_core" controls the GDSC, resets, and TLMM (GPIOs) whereas power domain "usb_transfer" controls clocks and interconnects. In this variant, two disjoint sets of resources are modeled against the power domain suppliers which can be turned on/off to achieve modeled device states. Two modeled low power states d1 and d3 are supported. transition: d0 <--> d3 :: both core and transfer suppliers transition: d0 <--> d1 :: only transfer supplier Signed-off-by: Sriram Dash Signed-off-by: Shazad Hussain Signed-off-by: Mattijs Korpershoek --- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 175 ++++++++++++++++++++++++++++---- 1 file changed, 155 insertions(+), 20 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c index c5507168e135..2ac6a23868bf 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -1411,6 +1412,9 @@ struct qmp_phy_cfg { /* Offset from PCS to PCS_USB region */ unsigned int pcs_usb_offset; + + /* true, if the device resources are fw managed */ + bool fw_managed; }; struct qmp_usb { @@ -1437,6 +1441,8 @@ struct qmp_usb { struct phy *phy; struct clk_fixed_rate pipe_clk_fixed; + + struct dev_pm_domain_list *pd_list; }; static inline void qphy_setbits(void __iomem *base, u32 offset, u32 val) @@ -1667,6 +1673,25 @@ static const struct qmp_phy_cfg qcs8300_usb3_uniphy_cfg = { .regs = qmp_v5_usb3phy_regs_layout, }; +static const struct qmp_phy_cfg sa8255p_usb3_uniphy_cfg = { + .offsets = &qmp_usb_offsets_v5, + + .serdes_tbl = sc8280xp_usb3_uniphy_serdes_tbl, + .serdes_tbl_num = ARRAY_SIZE(sc8280xp_usb3_uniphy_serdes_tbl), + .tx_tbl = sc8280xp_usb3_uniphy_tx_tbl, + .tx_tbl_num = ARRAY_SIZE(sc8280xp_usb3_uniphy_tx_tbl), + .rx_tbl = sc8280xp_usb3_uniphy_rx_tbl, + .rx_tbl_num = ARRAY_SIZE(sc8280xp_usb3_uniphy_rx_tbl), + .pcs_tbl = sa8775p_usb3_uniphy_pcs_tbl, + .pcs_tbl_num = ARRAY_SIZE(sa8775p_usb3_uniphy_pcs_tbl), + .pcs_usb_tbl = sa8775p_usb3_uniphy_pcs_usb_tbl, + .pcs_usb_tbl_num = ARRAY_SIZE(sa8775p_usb3_uniphy_pcs_usb_tbl), + .vreg_list = qmp_phy_vreg_l, + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), + .regs = qmp_v5_usb3phy_regs_layout, + .fw_managed = true, +}; + static const struct qmp_phy_cfg sc8280xp_usb3_uniphy_cfg = { .offsets = &qmp_usb_offsets_v5, @@ -1865,6 +1890,77 @@ static const struct qmp_phy_cfg glymur_usb3_uniphy_cfg = { .regs = qmp_v7_usb3phy_regs_layout, }; +static int qmp_usb_domain_attach(struct qmp_usb *qmp) +{ + struct dev_pm_domain_attach_data pd_data = { + .pd_flags = PD_FLAG_NO_DEV_LINK, + .pd_names = (const char*[]) { "usb_transfer", "usb_core" }, + .num_pd_names = 2, + }; + struct device *dev = qmp->dev; + int ret; + + ret = dev_pm_domain_attach_list(dev, &pd_data, &qmp->pd_list); + if (ret < 0) { + dev_err(dev, "domain attach failed %d)\n", ret); + return ret; + } + + return 0; +} + +static void qmp_usb_domain_detach(void *data) +{ + struct qmp_usb *qmp = data; + + dev_pm_domain_detach_list(qmp->pd_list); +} + +/* d3_to_d0 transition by turning on all the suppliers */ +static int qmp_usb_d3_to_d0(struct qmp_usb *qmp) +{ + int ret; + + if (!qmp->pd_list) + return 0; + + ret = pm_runtime_resume_and_get(qmp->pd_list->pd_devs[0]); + if (ret) + return ret; + + ret = pm_runtime_resume_and_get(qmp->pd_list->pd_devs[1]); + + return ret; +} + +/* d0_to_d3 transition by turning off all the suppliers */ +static void qmp_usb_d0_to_d3(struct qmp_usb *qmp) +{ + if (!qmp->pd_list) + return; + + pm_runtime_put_sync(qmp->pd_list->pd_devs[0]); + pm_runtime_put_sync(qmp->pd_list->pd_devs[1]); +} + +/* d1_to_d0 transition by turning on the 'tranfer' supplier */ +static int qmp_usb_d1_to_d0(struct qmp_usb *qmp) +{ + if (!qmp->pd_list) + return 0; + + return pm_runtime_resume_and_get(qmp->pd_list->pd_devs[0]); +} + +/* d0_to_d1 transition by turning off the 'tranfer' supplier */ +static void qmp_usb_d0_to_d1(struct qmp_usb *qmp) +{ + if (!qmp->pd_list) + return; + + pm_runtime_put_sync(qmp->pd_list->pd_devs[0]); +} + static int qmp_usb_serdes_init(struct qmp_usb *qmp) { const struct qmp_phy_cfg *cfg = qmp->cfg; @@ -1884,6 +1980,12 @@ static int qmp_usb_init(struct phy *phy) void __iomem *pcs = qmp->pcs; int ret; + ret = qmp_usb_d3_to_d0(qmp); + if (ret < 0) { + dev_err(qmp->dev, "Failed to transition to d0 state\n"); + return ret; + } + ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs); if (ret) { dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret); @@ -1923,6 +2025,8 @@ static int qmp_usb_exit(struct phy *phy) struct qmp_usb *qmp = phy_get_drvdata(phy); const struct qmp_phy_cfg *cfg = qmp->cfg; + qmp_usb_d0_to_d3(qmp); + reset_control_bulk_assert(qmp->num_resets, qmp->resets); clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); @@ -2108,6 +2212,8 @@ static int __maybe_unused qmp_usb_runtime_suspend(struct device *dev) qmp_usb_enable_autonomous_mode(qmp); + qmp_usb_d0_to_d1(qmp); + clk_disable_unprepare(qmp->pipe_clk); clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); @@ -2126,6 +2232,12 @@ static int __maybe_unused qmp_usb_runtime_resume(struct device *dev) return 0; } + ret = qmp_usb_d1_to_d0(qmp); + if (ret < 0) { + dev_err(qmp->dev, "Failed to transition to d0 state\n"); + return ret; + } + ret = clk_bulk_prepare_enable(qmp->num_clks, qmp->clks); if (ret) return ret; @@ -2313,10 +2425,12 @@ static int qmp_usb_parse_dt_legacy(struct qmp_usb *qmp, struct device_node *np) qmp->pcs_misc = NULL; } - qmp->pipe_clk = devm_get_clk_from_child(dev, np, NULL); - if (IS_ERR(qmp->pipe_clk)) { - return dev_err_probe(dev, PTR_ERR(qmp->pipe_clk), - "failed to get pipe clock\n"); + if (!qmp->cfg->fw_managed) { + qmp->pipe_clk = devm_get_clk_from_child(dev, np, NULL); + if (IS_ERR(qmp->pipe_clk)) { + return dev_err_probe(dev, PTR_ERR(qmp->pipe_clk), + "failed to get pipe clock\n"); + } } ret = devm_clk_bulk_get_all(qmp->dev, &qmp->clks); @@ -2325,10 +2439,12 @@ static int qmp_usb_parse_dt_legacy(struct qmp_usb *qmp, struct device_node *np) qmp->num_clks = ret; - ret = qmp_usb_reset_init(qmp, usb3phy_legacy_reset_l, - ARRAY_SIZE(usb3phy_legacy_reset_l)); - if (ret) - return ret; + if (!qmp->cfg->fw_managed) { + ret = qmp_usb_reset_init(qmp, usb3phy_legacy_reset_l, + ARRAY_SIZE(usb3phy_legacy_reset_l)); + if (ret) + return ret; + } return 0; } @@ -2362,17 +2478,19 @@ static int qmp_usb_parse_dt(struct qmp_usb *qmp) if (ret) return ret; - qmp->pipe_clk = devm_clk_get(dev, "pipe"); - if (IS_ERR(qmp->pipe_clk)) { - return dev_err_probe(dev, PTR_ERR(qmp->pipe_clk), - "failed to get pipe clock\n"); + if (!qmp->cfg->fw_managed) { + qmp->pipe_clk = devm_clk_get(dev, "pipe"); + if (IS_ERR(qmp->pipe_clk)) { + return dev_err_probe(dev, PTR_ERR(qmp->pipe_clk), + "failed to get pipe clock\n"); + } + + ret = qmp_usb_reset_init(qmp, usb3phy_reset_l, + ARRAY_SIZE(usb3phy_reset_l)); + if (ret) + return ret; } - ret = qmp_usb_reset_init(qmp, usb3phy_reset_l, - ARRAY_SIZE(usb3phy_reset_l)); - if (ret) - return ret; - return 0; } @@ -2395,6 +2513,18 @@ static int qmp_usb_probe(struct platform_device *pdev) if (!qmp->cfg) return -EINVAL; + if (qmp->cfg->fw_managed) { + ret = qmp_usb_domain_attach(qmp); + if (ret) { + dev_err(dev, "Failed to attach domains. Bail out\n"); + return ret; + } + + ret = devm_add_action_or_reset(dev, qmp_usb_domain_detach, qmp); + if (ret) + return ret; + } + ret = devm_regulator_bulk_get_const(dev, qmp->cfg->num_vregs, qmp->cfg->vreg_list, &qmp->vregs); if (ret) @@ -2421,9 +2551,11 @@ static int qmp_usb_probe(struct platform_device *pdev) */ pm_runtime_forbid(dev); - ret = phy_pipe_clk_register(qmp, np); - if (ret) - goto err_node_put; + if (!qmp->cfg->fw_managed) { + ret = phy_pipe_clk_register(qmp, np); + if (ret) + goto err_node_put; + } qmp->phy = devm_phy_create(dev, np, &qmp_usb_phy_ops); if (IS_ERR(qmp->phy)) { @@ -2470,6 +2602,9 @@ static const struct of_device_id qmp_usb_of_match_table[] = { }, { .compatible = "qcom,qdu1000-qmp-usb3-uni-phy", .data = &qdu1000_usb3_uniphy_cfg, + }, { + .compatible = "qcom,sa8255p-qmp-usb3-uni-phy", + .data = &sa8255p_usb3_uniphy_cfg, }, { .compatible = "qcom,sa8775p-qmp-usb3-uni-phy", .data = &sa8775p_usb3_uniphy_cfg, -- 2.54.0