Re: [PATCH v12 4/6] media: qcom: camss: Add legacy_phy flag to SoC definition structures

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `.legacy_phy = true` flag initialization for the `sm6350_resources` SoC definition.
--

--- Patch [4]: [PATCH v12 4/6] media: qcom: camss: Add legacy_phy flag to SoC definition structures ---
commit 909874316ccb4262ad4b5121de9b3eda2618f46a
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

media: qcom: camss: Add legacy_phy flag to SoC definition structures

This commit adds a legacy_phy flag to various SoC definition structures
to indicate which SoCs have builtin PHY code. This flag is intended to
inform PHY bringup logic in subsequent patches if legacy bindings are
available.

> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 95e655a8b6aa0..e814a96953b1b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
[ ... ]
> @@ -5661,6 +5672,7 @@ static const struct camss_resources sm6350_resources = {

[Severity: Medium]
Did we miss setting .legacy_phy = true for sm6350_resources?

Looking at the other SoC definitions in camss.c, they all receive the
.legacy_phy = true flag, but it appears sm6350_resources was skipped:

static const struct camss_resources sm6350_resources = {
	.version = CAMSS_6350,
	.pd_name = "top",
	.csiphy_res = csiphy_res_sm6350,
	.csid_res = csid_res_sm6350,
        ...
};

Will this cause SM6350 to incorrectly fall into the non-legacy path when
the PHY bringup logic is updated to rely on this flag?

>  static const struct camss_resources sm8250_resources = {
>  	.version = CAMSS_8250,
>  	.pd_name = "top",
> +	.legacy_phy = true,
>  	.csiphy_res = csiphy_res_8250,
>  	.csid_res = csid_res_8250,
>  	.vfe_res = vfe_res_8250,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v12-0-f8588da41f16@linaro.org?part=4