From: sashiko-bot@kernel.org
To: "Mukesh Kumar Savaliya" <mukesh.savaliya@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, robh@kernel.org,
dmaengine@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v8 1/4] dt-bindings: i2c: qcom,i2c-geni: Document multi-owner controller support
Date: Wed, 08 Jul 2026 05:19:54 +0000 [thread overview]
Message-ID: <20260708051954.E3E231F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260708051023.2872304-2-mukesh.savaliya@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] YAML syntax error in `qcom,qup-multi-owner` description due to missing block scalar indicator.
--
--- Patch [1]: [PATCH v8 1/4] dt-bindings: i2c: qcom,i2c-geni: Document multi-owner controller support ---
commit d38e4d9aefae5285416967f29ecb244ec4f2d7e0
Author: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
dt-bindings: i2c: qcom,i2c-geni: Document multi-owner controller support
This commit adds a boolean property to the qcom,i2c-geni device tree binding
to describe QUP-based I2C controllers that are shared across multiple system
processors. It notes that the operating system must not assume exclusive
ownership of such controllers or reconfigure associated GPIOs into sleep
states.
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> @@ -60,6 +60,22 @@ properties:
> power-domains:
> maxItems: 1
>
> + qcom,qup-multi-owner:
> + type: boolean
> + description:
> + Indicates that the QUP-based controller is shared with one or more
> + other system processors and must not be assumed to have exclusive
> + ownership by the operating system.
> +
> + The associated GPIOs must not be reconfigured into a sleep state
[Severity: Low]
Will this description format cause a YAML parsing error during a schema check?
Because the description spans multiple paragraphs separated by blank lines,
it appears to need a block scalar indicator (such as '|' or '>') immediately
following the 'description:' key.
Without it, a YAML 1.2 parser may treat the blank line as the end of the
scalar and fail to parse the next paragraph, throwing an error when it cannot
find a mapping key for the subsequent text.
> + during runtime suspend, as doing so may disrupt transactions
> + initiated by another owner of the controller.
> +
> + Each owner is responsible for maintaining any resource votes
> + required for operation of the shared controller (for example clocks,
> + power domains, interconnect bandwidth, or other platform-specific
> + resources)
> +
> reg:
> maxItems: 1
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260708051023.2872304-1-mukesh.savaliya@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-08 5:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:10 [PATCH v8 0/4] Enable multi-owner I2C support for QCOM GENI controllers Mukesh Kumar Savaliya
2026-07-08 5:10 ` [PATCH v8 1/4] dt-bindings: i2c: qcom,i2c-geni: Document multi-owner controller support Mukesh Kumar Savaliya
2026-07-08 5:19 ` sashiko-bot [this message]
2026-07-08 5:10 ` [PATCH v8 2/4] dmaengine: qcom: gpi: Add lock/unlock TREs for multi-owner I2C transfers Mukesh Kumar Savaliya
2026-07-08 5:32 ` sashiko-bot
2026-07-08 5:10 ` [PATCH v8 3/4] soc: qcom: geni-se: Keep pinctrl active for multi-owner controllers Mukesh Kumar Savaliya
2026-07-08 5:25 ` sashiko-bot
2026-07-08 5:10 ` [PATCH v8 4/4] i2c: qcom-geni: Support multi-owner controllers in GPI mode Mukesh Kumar Savaliya
2026-07-08 5:23 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708051954.E3E231F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox