From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 824C33ECBD2 for ; Wed, 8 Jul 2026 07:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783495679; cv=none; b=I+oi67vgujVafepFP0m9KTFS39Nvnxy/y/9yclUkYJE/ynFPC0RA6rsQSMp/4tzl6mSFgquajS85VS1Noa09SUJPYKADNk4MZ+UXGh3qfCfOEyGttolnKIs5aXjUIZz+ul18f/VjePUuAYyRw1PxiR/3qL7ZNegmWLEQCVGrku4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783495679; c=relaxed/simple; bh=cOLdpiEAtzaSryV6o6FyAVatG0tXci1ipsiFtSqcmR4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=QV/dSSxIo0qZiAcMP5CktvN8qVQVkb+IjkHuPC9uDHbx2rdd4a7vDw+GM8Y/OWtd+FChQr3iF/uew3N9WZpgFbHFc63RhspYknvvkub/Gu34d2oVqMedYHSTX353RfrsOTGW36ffvDmoeCfUeeq/41vStnPcAkB3zPE0eWSMYVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iUlNdHcr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iUlNdHcr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9854A1F000E9; Wed, 8 Jul 2026 07:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783495664; bh=cOLdpiEAtzaSryV6o6FyAVatG0tXci1ipsiFtSqcmR4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=iUlNdHcreiytk9Iz7jOApEy/oc2P63PgHYGb+12kLeJeN7fhWVI5oYphHkZpSuYNq QYRLe0LlFoDtV5mePLjONQPvaAbFl6Sk/8j8DGorAUfXhCBU1ebOfj2dFCcWBnu5W0 lI4+Y7ICvxf+YZIB7h1oz/VrwmrwCZaOueWWgXZcUhBZFSHkcJGc0osMbNyklCHX/7 +gMSTX6Is9eUt4WefXQoB9i8+23+yGxgMCVrdZSe5ZYMyWT6dedZ6tCQA9xUnKGkBo ae2Ig7q6zXlQ8uip9Y1vC6njg+fsGIPhS4dUF5XRaW4eiLM42dJHvkWgek/DCfRvGl m+Lnspxhq6EQA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 1/5] dt-bindings: firmware: xilinx: Add missing example for ZynqMP Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Simek" Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <09439b3fc9dcab12b930113e7a004e94653c970c.1783495122.git.michal.simek@amd.com> References: <09439b3fc9dcab12b930113e7a004e94653c970c.1783495122.git.michal.simek@amd.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 08 Jul 2026 07:27:44 +0000 Message-Id: <20260708072744.9854A1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The commit message incorrectly references `xlnx,zynqmp-clk.yaml` in= stead of `xlnx,versal-clk.yaml`. -- --- Patch [1]: [PATCH v4 1/5] dt-bindings: firmware: xilinx: Add missing ex= ample for ZynqMP --- commit f76bb0fabd5ddf2fd379360e863c083c04812eff Author: Michal Simek dt-bindings: firmware: xilinx: Add missing example for ZynqMP This commit adds the clock-controller to the zynqmp-firmware example in the device tree binding. This allows ZynqMP device trees to properly validate against the clock schema. > Document clock-controller under zynqmp-firmware in the binding example so > ZynqMP DTs validate against xlnx,zynqmp-clk.yaml (Versal example already = did). [Severity: Low] This isn't a bug, but the commit message references xlnx,zynqmp-clk.yaml, which does not appear to exist in the repository. Should the message specify xlnx,versal-clk.yaml instead, since that is what the hardware actually validates against? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1783495122.gi= t.michal.simek@amd.com?part=3D1