Re: [PATCH 1/2] dt-bindings: PCI: mediatek: Add support for optional perstout reset

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces a typo `resets-names:` instead of `reset-names:` in the `airoha,an7583-pcie` conditional block.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: PCI: mediatek: Add support for optional perstout reset ---
commit 940c7b8d9eadf01ceca0b3e3526e890e946e92a5
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: PCI: mediatek: Add support for optional perstout reset

This commit adds optional schema support for a dedicated PCIe PERSTOUT reset
on Airoha AN7583 devices. It bumps the maximum items for resets and
reset-names, and adds specific name constraints in the conditional block.

> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
[ ... ]
> @@ -127,6 +129,12 @@ allOf:
>          phy-names:
>            const: pcie-phy1
>  
> +        resets-names:

[Severity: Medium]
This isn't a runtime bug, but there appears to be a typo in this property
name (resets-names instead of reset-names). Will this cause the DT binding
schema validation to ignore these constraints and silently allow incorrectly
ordered values for the reset-names property?

> +          minItems: 1
> +          items:
> +            - const: pcie-rst1
> +            - const: pcie-perstout1
> +
>          power-domain: false
>  
>        required:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708090533.19734-1-ansuelsmth@gmail.com?part=1