From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8699038AC97 for ; Wed, 8 Jul 2026 10:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783505174; cv=none; b=TVyaYP7eoHjYizopeUTbn9LlJU4SKrWslEIkz7nB7gSkKkMNXzSO7C8CNeDH6wQpNWcvknfxzRoNiHxsNEIlO4VH0bbisSZdN9MGyUGT6kxc2Vg/eBARW3UVPx31tu+uWM+k93Mhov/t08E2xPTCFuXwBWT7zIX2mXzJ09Ztu0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783505174; c=relaxed/simple; bh=B6MeDfUG5mQDlM5l3gQa1XAIk9thgxnE2L1Aq+NjufY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=KPeT+yW5BSFwv2gJ7Q5co+UkDRXKCuSvhPxya+68raWqSt2LLouajKEkM1DYJ1dJ0IoUAFA+u00X3aQKikOVYQxMXZiFmPtyHjiwliU9y54/fsrECC/oeiLKIrn395eB2IEy/HKoXvxHTYzbELUXoeIsvI2ZTOUTwFxH1jpSfp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fNhDvOVX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fNhDvOVX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D54441F000E9; Wed, 8 Jul 2026 10:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783505173; bh=bixFD+WckKB6s0N2ii1HpnfCILr1sSnwWjZ8gZcqZN4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fNhDvOVX82OPYdHIMXwXvYXC4iKgBv6T90CX+MbBsx4SvnahmlUm2HfE480AZfa8F k82fxSwl6PUspLTCOCEA1QJm467FLM9RUflWrcP6GnViap87FXwAV+ArP07RtRgXmL 91OBwoOMOMxepmW05RD4eM4gjbhmhVlO6nOvuey4nu8n4qWefGnI6ckiLJclPtkcKq a9FApjTLJ5u1OiDnrCUBm9SQ4v+Z1ezKuvUH2IzWFTit8uD4uMk4nRQjoZLisMJQ5H yIF7Y7phHJK3+1RZEOaxkSXHHCtpwfMs2HRWTux/E/nvyOpFrNQuwjGa+x9bbLgrPC T6ylHhPL1M5kg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163 Reply-To: sashiko-reviews@lists.linux.dev To: "Lukas Metz" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260708-dac8163-work-v2-1-3acd1bf20182@gmx.net> References: <20260708-dac8163-work-v2-0-3acd1bf20182@gmx.net> <20260708-dac8163-work-v2-1-3acd1bf20182@gmx.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 08 Jul 2026 10:06:12 +0000 Message-Id: <20260708100612.D54441F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The device tree binding uses the non-standard `clr-gpios` property = name for a reset line instead of the standard `reset-gpios`. -- --- Patch [1]: [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163 --- commit f211d5a7de6b208a53302eba555c43258dd0918b Author: Lukas Metz dt-bindings: iio: dac: Add DAC8163 Add device tree binding for the Texas Instruments DAC8163 family including the DAC7562, DAC7563, DAC8162, DAC8163, DAC8562 and DAC8563. > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml b/= Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml > new file mode 100644 > index 0000000000000..533cc7327c2b6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml [ ... ] > + avdd-supply: true > + > + clr-gpios: > + description: > + The device registers are reset when this pin is asserted. The outp= ut is > + set to zero (xxx2 devices) or mid-scale (xxx3 devices). > + maxItems: 1 [Severity: Low] Is clr-gpios the correct name for this property? The description indicates = it functions as a reset line. Should this use the standard reset-gpios property name instead of a datasheet-specific pin name? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260708-dac8163-wo= rk-v2-0-3acd1bf20182@gmx.net?part=3D1