Re: [PATCH v7 5/5] arm64: dts: qcom: Add Shikra EVK boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The CQS EVK board incorrectly includes the SoM device tree for the CQM variant, logically coupling a modem-less platform to a modem-equipped platform.
--

--- Patch [5]: [PATCH v7 5/5] arm64: dts: qcom: Add Shikra EVK boards ---
commit 4fcaf27e44972f2edd1677d38c5edd3906fd3d1a
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

arm64: dts: qcom: Add Shikra EVK boards

This commit adds device trees for the Shikra EVK platform, covering the
CQ2390M, CQ2390S, and IQ2390S SoM variants. It also introduces a common
carrier-board configuration shared across all variants.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> new file mode 100644
> index 0000000000000..b3f19a64d7aed
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +
> +#include "shikra-cqm-som.dtsi"

[Severity: Low]
Is this the intended SoM include for the CQS EVK board?

This file appears to include the device tree for the CQM (with modem)
variant instead of the CQS variant. While it might currently only define shared
configurations, future CQM-specific additions could inadvertently propagate to
the CQS platform.

Should this include a CQS-specific or shared base .dtsi instead?

> +#include "shikra-evk.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. Shikra CQS EVK";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-shikra-dt-v7-0-977b65a300c1@oss.qualcomm.com?part=5