Re: [PATCH] dt-bindings: net: convert microchip,lan78xx.txt to YAML schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `ethernet-phy` node schema (which validates `microchip,led-modes`) is incorrectly placed at the root level of the ethernet controller schema instead of within the `mdio` node, causing PHY properties to silently bypass validation.
--

--- Patch [1]: [PATCH] dt-bindings: net: convert microchip,lan78xx.txt to YAML schema ---
commit d20f485d326a6780c198391c5453a7f4df19b905
Author: Mikhail Lukianchikov <avermoal@gmail.com>

dt-bindings: net: convert microchip,lan78xx.txt to YAML schema
    
Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema format using YAML.

> diff --git a/Documentation/devicetree/bindings/net/microchip,lan78xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan78xx.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan78xx.yaml

[ ... ]

> +  mdio:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false
> +
> +patternProperties:
> +  "^ethernet-phy(@[0-9a-f]+)?$":

[Severity: Medium]
Should this patternProperties block for the ethernet-phy node be nested
inside the mdio property definition rather than at the root level of the
ethernet controller schema?

Because this rule applies to the root level instead of child nodes of mdio,
properties like microchip,led-modes bypass schema validation. Malformed
property values will silently pass dt_binding_check.

> +    type: object
> +    description: |
> +      PHY node for the embedded or external PHY. The PHY address is
> +      given by the 'reg' property.

[ ... ]

> +                    mdio {
> +                        #address-cells = <1>;
> +                        #size-cells = <0>;
> +                        ethernet-phy@1 {
> +                            reg = <1>;
> +                            microchip,led-modes = <

[Severity: Medium]
As correctly shown in this example, the ethernet-phy node resides inside
mdio. 

Could the schema definition above be updated to match this structure so the
PHY properties are properly evaluated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707165840.107409-1-avermoal@gmail.com?part=1