Re: [PATCH v2 1/4] dt-bindings: crypto: rockchip: Add RK356x/RK3588 crypto engine binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML binding artificially restricts the `resets` property to a single item (`maxItems: 1`), which prevents the complete representation of the hardware's reset lines on both RK3568 and RK3588.
--

--- Patch [1]: [PATCH v2 1/4] dt-bindings: crypto: rockchip: Add RK356x/RK3588 crypto engine binding ---
commit d3ca14a283793e220819f2a5573b09896dfccc6d
Author: Dawid Olesinski <dawidro@gmail.com>

dt-bindings: crypto: rockchip: Add RK356x/RK3588 crypto engine binding

Add a YAML device tree binding for the Rockchip second-generation (V2)
cryptographic hardware accelerator present on the RK3568 and RK3588 SoCs.
The binding covers the rockchip,rk3568-crypto and rockchip,rk3588-crypto
compatible strings.

> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
> new file mode 100644
> index 0000000000000..fc09f21b06549
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml
[ ... ]
> +  clocks:
> +    items:
> +      - description: Core clock for the crypto IP internal logic
> +      - description: AXI interconnect clock interface
> +      - description: AHB interface clock
> +
> +  clock-names:
> +    items:
> +      - const: core
> +      - const: aclk
> +      - const: hclk
> +
> +  resets:
> +    maxItems: 1
> +
> +  reset-names:
> +    items:
> +      - const: core

[Severity: Medium]
Since the hardware block has AXI and AHB interfaces that require corresponding
clocks, should the binding also accommodate reset lines for AXI and AHB (e.g.,
SCMI_SRST_A_CRYPTO and SCMI_SRST_H_CRYPTO on the RK3588)?

Restricting resets to maxItems: 1 prevents a complete device tree node from
accurately describing the hardware's AXI and AHB resets alongside the core
reset, which would cause schema validation failures.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708175837.1718437-1-dawidro@gmail.com?part=1