Re: [PATCH v9 1/3] dt-bindings: media: mediatek-jpeg-decoder: add MT8189 compatible string

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit introduces a new mandatory property `mediatek,larb` for the MT8189 JPEG decoder, but this addition is completely undocumented in the commit message.
--

--- Patch [1]: [PATCH v9 1/3] dt-bindings: media: mediatek-jpeg-decoder: add MT8189 compatible string ---
commit e0e1e554d3c1d037a7084628a317111dade87379
Author: Jianhua Lin <jianhua.lin@mediatek.com>

dt-bindings: media: mediatek-jpeg-decoder: add MT8189 compatible string

This commit adds the compatible string for the JPEG decoder found in the
MediaTek MT8189 SoC. It updates the schema to enforce a single clock
requirement for the new SoC while maintaining the two-clock requirement for
older SoCs.

> diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml
> index a4aacd3eb189b..13fb4fb61f2bc 100644
> --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-decoder.yaml
[ ... ]
> @@ -51,6 +54,15 @@ properties:
>        Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
>        Ports are according to the HW.
>  
> +  mediatek,larb:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      A phandle to the local arbiter (SMI LARB) node. This explicitly
> +      describes the hardware topology where the JPEG block is connected
> +      to a dedicated SMI LARB for memory bandwidth arbitration. It is
> +      required to accurately represent the hardware connection independently
> +      of the IOMMU.
> +

[Severity: Medium]
The schema introduces mediatek,larb as a new property, but this addition
is completely undocumented in the commit message.

The commit message explicitly details the 34-bit IOVA address space and the
single clock requirement, but fails to mention this local arbiter phandle.

Could the commit message be updated to explain this hardware topology change
and why it is mandatory for the MT8189?

>  required:
>    - compatible
>    - reg
[ ... ]
> +      required:
> +        - mediatek,larb
> +    else:
> +      properties:
> +        clocks:
> +          minItems: 2
> +        clock-names:
> +          minItems: 2
> +
>  additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709032657.25730-1-jianhua.lin@mediatek.com?part=1