Re: [PATCH v4 5/6] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `spacemit,k3-pcie` variant drops the requirement for `interrupts` without enforcing an alternative like `msi-parent` or `msi-map`, allowing incomplete device tree nodes to silently pass validation.
--

--- Patch [5]: [PATCH v4 5/6] dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller ---
commit 2fd5f19d10e79ab1400e6aaebad38037440b1cb4
Author: Inochi Amaoto <inochiama@gmail.com>

dt-bindings: PCI: spacemit: Introduce Spacemit K3 PCIe host controller

This commit adds device tree binding support for the PCIe controller on the
SpacemiT K3 SoC. It introduces a new compatible string and modifies the
schema constraints to accommodate differing register counts and interrupt
configurations between the K1 and K3 variants.

> diff --git a/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml b/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
> index c4c00b5fcdc0c..54817d6fd9afe 100644
> --- a/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/spacemit,k1-pcie-host.yaml

[ ... ]

> @@ -102,13 +102,43 @@ patternProperties:
>  
>      unevaluatedProperties: false
>  
> +allOf:
> +  - $ref: /schemas/pci/snps,dw-pcie.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: spacemit,k1-pcie
> +    then:

[ ... ]

> +      required:
> +        - interrupts
> +        - interrupt-names
> +    else:
> +      properties:
> +        reg:
> +          minItems: 5
> +
> +        reg-names:
> +          minItems: 5

[Severity: Medium]
Since interrupts and interrupt-names were removed from the global required
list below, should this else block enforce an alternative interrupt
requirement for the spacemit,k3-pcie controller, such as msi-parent or
msi-map?

Does this regression allow device tree nodes for spacemit,k3-pcie that are
missing both interrupts and msi-parent to silently pass schema validation,
potentially failing at runtime due to lacking an MSI domain or interrupt
line?

>  required:
>    - clocks
>    - clock-names
>    - resets
>    - reset-names
> -  - interrupts
> -  - interrupt-names
>    - spacemit,apmu
>  
>  unevaluatedProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709040027.958400-1-inochiama@gmail.com?part=5