From: sashiko-bot@kernel.org
To: "HaoNing Cheng" <Haoning.CHENG@cn.bosch.com>
Cc: imx@lists.linux.dev, devicetree@vger.kernel.org, robh@kernel.org,
Frank.Li@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: thermal: imx: Document calibration offset property
Date: Thu, 09 Jul 2026 05:50:38 +0000 [thread overview]
Message-ID: <20260709055038.BF1E61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260709-b4-symana21-11221-imx-thermal-support-upstream-6-18-v1-1-00f88f42930b@cn.bosch.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inconsistent indentation in the device tree example for the newly added property.
--
--- Patch [1]: [PATCH 1/2] dt-bindings: thermal: imx: Document calibration offset property ---
commit 1a75813b8a61f5ee87309553dc49a0dab98ae1c1
Author: HaoNing Cheng <Haoning.CHENG@cn.bosch.com>
dt-bindings: thermal: imx: Document calibration offset property
This commit documents a new optional property,
fsl,temp-calibration-offset-millicelsius, to align the reported CPU
temperature with board-level measurements. The binding example is also
updated to demonstrate its usage.
> diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> --- a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
[ ... ]
> @@ -109,6 +116,7 @@ examples:
> nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
> nvmem-cell-names = "calib", "temp_grade";
> clocks = <&clks IMX6SX_CLK_PLL3_USB_OTG>;
> + fsl,temp-calibration-offset-millicelsius = <(-6400)>;
[Severity: Low]
This isn't a bug, but does this line have an extra leading space? It appears
to be indented with 13 spaces instead of 12, misaligning it slightly with the
surrounding properties in the example.
> #thermal-sensor-cells = <0>;
> };
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-b4-symana21-11221-imx-thermal-support-upstream-6-18-v1-0-00f88f42930b@cn.bosch.com?part=1
next prev parent reply other threads:[~2026-07-09 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 5:43 [PATCH 0/2] thermal: imx: Add calibration offset support HaoNing Cheng via B4 Relay
2026-07-09 5:43 ` [PATCH 1/2] dt-bindings: thermal: imx: Document calibration offset property HaoNing Cheng via B4 Relay
2026-07-09 5:50 ` sashiko-bot [this message]
2026-07-09 6:26 ` Rob Herring (Arm)
2026-07-09 5:43 ` [PATCH 2/2] thermal/drivers/imx: Add calibration offset support HaoNing Cheng via B4 Relay
2026-07-09 5:54 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709055038.BF1E61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Haoning.CHENG@cn.bosch.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox