Re: [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `interrupts` property is missing from the `required` list in the binding schema.
--

--- Patch [1]: [PATCH v10 1/2] dt-bindings: i3c: Add AMD I3C master controller support ---
commit dfcd0f962dd67901f67582456a8fe5271491789d
Author: Manikanta Guntupalli <manikanta.guntupalli@amd.com>

dt-bindings: i3c: Add AMD I3C master controller support

This commit adds device tree binding documentation for the AMD I3C master
controller version 1.0.

> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
> new file mode 100644
> index 0000000000000..2caa245a86568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml

[ ... ]

> +properties:
> +  compatible:
> +    const: xlnx,axi-i3c-1.0
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks

[Severity: Medium]
Should the interrupts property be included in this required list?

Since I3C master controllers fundamentally rely on interrupts for handling
asynchronous bus events like In-Band Interrupts (IBIs) and Dynamic Address
Assignment (DAA), a missing requirement allows incomplete device tree nodes
to pass YAML schema validation. Will this lead to driver probe or runtime
failures when the software attempts to acquire the missing IRQ?

> +
> +allOf:
> +  - $ref: i3c.yaml#

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709064233.1451482-1-shubhamsanjay.patil@amd.com?part=1