Re: [PATCH v5 1/2] media: dt-bindings: Add Himax HM1092 NIR sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `data-lanes` property is unconstrained in the MIPI CSI-2 endpoint, allowing invalid hardware configurations to pass validation.
--

--- Patch [1]: [PATCH v5 1/2] media: dt-bindings: Add Himax HM1092 NIR sensor ---
commit c0fd35985ccc449c8ccfd7a8009b9fa4c8298ef0
Author: Ramshouriesh R <rshouriesh@gmail.com>

media: dt-bindings: Add Himax HM1092 NIR sensor

This commit adds a device tree binding schema for the Himax HM1092, a 1
megapixel monochrome near-infrared CMOS image sensor. The sensor streams
10-bit RAW data over a single MIPI CSI-2 data lane.

> diff --git a/Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml b/Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/himax,hm1092.yaml

[ ... ]

> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        required:
> +          - link-frequencies

[Severity: Low]
The commit message mentions that the sensor streams over a single MIPI
CSI-2 data lane. Should this endpoint definition include a constraint for
data-lanes (for example, maxItems: 1) to prevent invalid hardware
configurations with multiple lanes from passing schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-hm1092-driver-v5-0-a1f5baa6fe08@gmail.com?part=1