From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0983806DA for ; Thu, 9 Jul 2026 08:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783585284; cv=none; b=XHd3q4KJEJovdgmpiZ/uRm36hruaw4vtM2m814FLfJYF+EAzXTwwuCDRnbaCfD62pI31Cu1I9O0tLejhc/CRl2Q+KtDc2Mj1qFLz22A7iHJ0xBn/fXqHIXt8vJr15Kmo5qvzlPdOaICl2Po7xXaIEB3r9DuYXBJmbJRkmSjj1Tk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783585284; c=relaxed/simple; bh=r3Jk4OeCeSCMckN3G7/P43GE2DIEl2CozrfLujCjZIQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=czLsXLuqo7MBA0eD0Bsz28g9X7VktleQ5wawHUgu4NPgputSvp3w/Hb/yyq2PlpNZHJcIvICsR9Q9R7+EMW+rc5dLF2+pJLYVGLdKN+6zpx2PAs17h6GqHNLUXP3iPbCv3/LdKjHPKzLA4crz7qnAlR1BesuX5x5USO2kEebA1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dup8Edkk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dup8Edkk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74A441F000E9; Thu, 9 Jul 2026 08:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783585282; bh=h7c/LMLHj/6CUGJ3vGorc72UpibHKg51BF1b1Afr+Rw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Dup8EdkkQOQOL7zUMSk2IlAujkoypH73reLWcjM+suNg++T0q28CDSJNkHaMbE3TC VQA3OMN8ND5vWHk4JTfuksz0NzCINMweUhBc9DlCtgT0TGV+p2IlEp7uVXjmHdnVaX vRs0wgEPT1vuN5xZ7i7+Nozz54NwG1EiIxCtXpyfx5tL1NWzoUTq9yq+hgTA3w3aSJ lqquoxvt87Zsn8zugwZs78BbCoQSTykG8lyKNhOOeyiPwzNR2ZHAr3bOwtbx2GxpX+ 5SPQHnVQCLcrXFccl9HnD5BrwP2pJE2QmdmoZOS6j/8spfSWK+dqiEQUlZMH/518q5 Lb47kpflhWnBA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: kaanapali-qrd: Add SoCCP node Reply-To: sashiko-reviews@lists.linux.dev To: "Jingyi Wang" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260709-knp-soccp-dt-v2-2-6e2bfca96088@oss.qualcomm.com> References: <20260709-knp-soccp-dt-v2-0-6e2bfca96088@oss.qualcomm.com> <20260709-knp-soccp-dt-v2-2-6e2bfca96088@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Jul 2026 08:21:22 +0000 Message-Id: <20260709082122.74A441F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The board-specific `&remoteproc_soccp` node is missing the `stat= us =3D "okay";` property, relying on a flawed default in the base device tr= ee. -- --- Patch [2]: [PATCH v2 2/3] arm64: dts: qcom: kaanapali-qrd: Add SoCCP no= de --- commit 499497fe00069ecefb1bec759006b9907810f4e3 Author: Jingyi Wang arm64: dts: qcom: kaanapali-qrd: Add SoCCP node This commit adds the remote processor firmware configuration for the SoCCP node on the Kaanapali QRD board. > diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot= /dts/qcom/kaanapali-qrd.dts > index 55d02219ef4e9..8ac1c664a7fd4 100644 > --- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts [ ... ] > @@ -786,6 +786,11 @@ &remoteproc_cdsp { > status =3D "okay"; > }; > =20 > +&remoteproc_soccp { > + firmware-name =3D "qcom/kaanapali/soccp.mbn", > + "qcom/kaanapali/soccp_dtb.mbn"; > +}; [Severity: Medium] Should this node explicitly include a status =3D "okay"; property? While the node might currently function if the base kaanapali.dtsi omitted a status =3D "disabled"; declaration, standard Qualcomm remoteproc conventi= ons typically disable remote processors by default in the base device tree. If the base device tree is later corrected to follow this convention, the SoCCP could silently become disabled on this board because it lacks an explicit enable here. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260709-knp-soccp-= dt-v2-0-6e2bfca96088@oss.qualcomm.com?part=3D2