From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C0F3B4EAC for ; Thu, 9 Jul 2026 08:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783587576; cv=none; b=twqiecJIyhk/v0w9hG6n7qO9DAMsa395A2JfbkqCCi1lYKjt61S0qJOO/AyLq66z5itQDYlCTkLgjRfvrtJA/ga1BbidzXFHw0YWRl444FgDvbhDI6dhzgu90EDJLVKH9ecLCwpDANUKD6Zh2eCkYatlcU/yJA3CTn/0LBdQ16k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783587576; c=relaxed/simple; bh=5DaP12Bz65Qb6UkGn5XK4JavZma+x3hvARAlXzqn6gI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=KFrjJcahGOYGWUM2D9fCV7mcbQRVl0GDnDQ9JvPHlUmeeLbMVICx2KZIZgxvCeOgWjncLiZ7YA9x83oB1fZ5yFypQnGEeMF7g0xhB+BOVC0lnNeMSFs77HWzBwdU9ZwuTyeBXExzJRinOqws1U9jPGg4bly2eHWciIoygmOsMlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QtdKD+sT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QtdKD+sT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D02931F000E9; Thu, 9 Jul 2026 08:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783587575; bh=t9Z8dKcBGlwYOZ1LVBMQp6vcE3XgL9kDtaI5AWuuzko=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QtdKD+sTK/g3GH1Q8ejalSqzpQEpQ9+Ng+tYOM4nZlVi04yS2e1IXWEaIzFPn581F Gt93F64ZTeFfzsU8Oe2xFhH2847wQZEmJeEVJSYpjXuGzJdyo9pQLOVMmCi0Zpei/p ec8rvEAIBfzKhU7fIiGhydB4/hQc3Jcu7IlWBo+yeqIVCVc6Y9bqKbziyzbKVdyQ2K Q/fbUaPYM983t/8cAQGR/RwG1ncj9w7plGOIYZwpHyOxZg4EU8w5uiSR/9Z+TtO0uC Z8sIgbjms6GGyCLrAFoCeu4EqtVuHh669IWNj5tqLoihNFspwCAkR0MEGZO9QsXONf FcIPii6gvrozg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 Reply-To: sashiko-reviews@lists.linux.dev To: "Janani Sunil" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260709-ad7768-driver-v1-1-44e1194fd96a@analog.com> References: <20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com> <20260709-ad7768-driver-v1-1-44e1194fd96a@analog.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Jul 2026 08:59:34 +0000 Message-Id: <20260709085934.D02931F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Hardware Variant Required Properties Violation: Missing GPIO pro= vider properties in the required list -- --- Patch [1]: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 --- commit b348e8650b6dd32f354ad1a32b48736f30d333db Author: Janani Sunil dt-bindings: iio: adc: Add AD7768 Devicetree Bindings for AD7768-4 (4 channel) and AD7768 (8 channel) simultaneous sampling ADC > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml b/= Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml > new file mode 100644 > index 0000000000000..b74fe6aef01c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml [ ... ] > +required: > + - compatible > + - reg > + - clocks > + - avdd-supply > + - avss-supply > + - dvdd-supply > + - iovdd-supply > + - vref-supply > + - adi,data-lines-number > + - adi,common-mode-output > + - io-backends [Severity: Medium] Since this hardware provides GPIO capabilities, should gpio-controller and #gpio-cells be included in this required list? Omitting these allows incomplete device tree nodes to silently pass schema validation. [ ... ] > + - | > + spi { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + adc@1 { > + compatible =3D "adi,ad7768-4"; > + reg =3D <1>; > + spi-max-frequency =3D <1000000>; > + > + avdd-supply =3D <&avdd_regulator>; > + avss-supply =3D <&avss_regulator>; > + dvdd-supply =3D <&dvdd_regulator>; > + iovdd-supply =3D <&iovdd_regulator>; > + vref-supply =3D <&vref_regulator>; > + > + clocks =3D <&ad7768_mclk>; > + > + adi,data-lines-number =3D <4>; > + adi,common-mode-output =3D "2.14V"; > + adi,power-mode =3D "fast"; > + > + io-backends =3D <&iio_backend>; [Severity: Medium] If the GPIO properties are added to the required list, they will also need to be included in this example block to pass dt_binding_check validation. Could gpio-controller and #gpio-cells =3D <2>; be added here? > + > + #address-cells =3D <1>; > + #size-cells =3D <0>; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260709-ad7768-dri= ver-v1-0-44e1194fd96a@analog.com?part=3D1