Re: [PATCH v1 03/11] spi: dw: update SPI_CTRLR0 register

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly introduced `enh_cfg` parameter in `dw_spi_update_config()` is never populated or passed by any caller, rendering the enhanced mode configuration logic effectively dead code.
--

--- Patch [3]: [PATCH v1 03/11] spi: dw: update SPI_CTRLR0 register ---
commit b571b86cd59a7cddd50fbc1933264b4589cd6f16
Author: Sudip Mukherjee <sudip.mukherjee@sifive.com>

spi: dw: update SPI_CTRLR0 register

This commit updates the SPI DesignWare driver to configure the SPI_CTRLR0
register for enhanced mode transfers. It introduces a new dw_spi_enh_cfg
structure and passes it to dw_spi_update_config() to set up instruction 
lengths, address lengths, and wait cycles.

> diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
> index 8d4ad4035d7c9..6befe47929b4c 100644
> --- a/drivers/spi/spi-dw-core.c
> +++ b/drivers/spi/spi-dw-core.c
[ ... ]
> @@ -451,7 +460,7 @@ static int dw_spi_transfer_one(struct spi_controller *ctlr,
>  
>  	dw_spi_enable_chip(dws, 0);
>  
> -	dw_spi_update_config(dws, spi, &cfg);
> +	dw_spi_update_config(dws, spi, &cfg, NULL);

[Severity: Medium]
Is this intended to always be NULL here? By passing NULL unconditionally, 
the new enhanced configuration block in dw_spi_update_config() will never 
execute for this path.

[ ... ]
> @@ -718,7 +727,7 @@ static int dw_spi_exec_mem_op(struct spi_mem *mem, const struct spi_mem_op *op)
>  
>  	dw_spi_enable_chip(dws, 0);
>  
> -	dw_spi_update_config(dws, mem->spi, &cfg);
> +	dw_spi_update_config(dws, mem->spi, &cfg, NULL);

[Severity: Medium]
Similarly in dw_spi_exec_mem_op(), the enh_cfg parameter is also 
unconditionally passed as NULL. Is there a missing piece that was supposed 
to extract the enhanced mode configurations from the memory operation and 
pass them along? 

Since all current callers provide NULL, the newly added SPI_CTRLR0 register 
update logic inside dw_spi_update_config() appears to be permanently 
unreachable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709055204.138168-1-changhuang.liang@starfivetech.com?part=3