Re: [PATCH v7 16/18] media: iris: add Gen2 firmware support on the Agatti platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect maximum QP limit for HEVC encoding in the Gen2 firmware capabilities for the Agatti platform.
--

--- Patch [16]: [PATCH v7 16/18] media: iris: add Gen2 firmware support on the Agatti platform ---
commit c95f463971a4ef87470f272f24b4d448ca8c4ba8
Author: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>

media: iris: add Gen2 firmware support on the Agatti platform

This commit extends the Agatti platform support in the iris driver to
include HFI Gen2 firmware capabilities. It defines the capability
structures, configuration parameters, and initialization data for Gen2
encoding and decoding on the AR50LT VPU.

> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c
> @@ -1118,3 +1118,616 @@ const struct iris_firmware_data iris_hfi_gen2_data = {

[ ... ]

> +static const struct platform_inst_fw_cap inst_fw_cap_gen2_ar50lt_enc[] = {

[ ... ]

> +	{
> +		.cap_id = MAX_FRAME_QP_HEVC,
> +		.min = MIN_QP_8BIT_AR50LT,
> +		.max = MAX_QP,
> +		.step_or_mask = 1,
> +		.value = MAX_QP,
> +		.hfi_id = HFI_PROP_MAX_QP_PACKED,
> +		.flags = CAP_FLAG_OUTPUT_PORT,
> +		.set = iris_set_max_qp,
> +	},

[Severity: Medium]
Should the maximum bound for MAX_FRAME_QP_HEVC be set to MAX_QP_HEVC (63)
instead of MAX_QP (51)? This limits userspace from setting HEVC QPs between
52 and 63, which are valid values for HEVC encoding.

[ ... ]

> +	{
> +		.cap_id = I_FRAME_MAX_QP_HEVC,
> +		.min = MIN_QP_8BIT_AR50LT,
> +		.max = MAX_QP,
> +		.step_or_mask = 1,
> +		.value = MAX_QP,
> +	},

[Severity: Medium]
Does this also incorrectly limit the I-frame maximum QP to 51 instead of 63?
This same MAX_QP limit appears to be applied to P_FRAME_MAX_QP_HEVC and
B_FRAME_MAX_QP_HEVC in the array below.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com?part=16