Re: [PATCH v5 2/2] remoteproc: add AMD MicroBlaze/V BRAM-based remote processor driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The driver references multiple non-existent functions (`rproc_mem_entry_ioremap_wc`, `rproc_mem_entry_iounmap`, and `rproc_elf_load_rsc_table_optional`) and illegally passes a variadic macro as an argument, causing a build failure.
--

--- Patch [2]: [PATCH v5 2/2] remoteproc: add AMD MicroBlaze/V BRAM-based remote processor driver ---
commit fa5c15f78fe1b684bd57e7c11e3674d5ed2661ce
Author: Ben Levinsky <ben.levinsky@amd.com>

remoteproc: add AMD MicroBlaze/V BRAM-based remote processor driver

Add a remoteproc driver for AMD MicroBlaze/V soft-core processor
subsystems instantiated in programmable logic and using dual-port BRAM
for firmware storage and execution.

> diff --git a/drivers/remoteproc/amd_bram_rproc.c b/drivers/remoteproc/amd_bram_rproc.c
> new file mode 100644
> index 0000000000000..e4a103cf84558
> --- /dev/null
> +++ b/drivers/remoteproc/amd_bram_rproc.c
[ ... ]
> +static int amd_bram_rproc_prepare(struct rproc *rproc)
> +{
[ ... ]
> +	ret = of_address_to_resource(priv->dev->of_node, 0, &res);
> +	if (ret) {
> +		dev_err(priv->dev, "failed to translate executable memory reg\n");
> +		return ret;
> +	}
> +
> +	mem = rproc_mem_entry_init(priv->dev, NULL, (dma_addr_t)res.start,
> +				   resource_size(&res), da,
> +				   rproc_mem_entry_ioremap_wc,
> +				   rproc_mem_entry_iounmap,
> +				   dev_name(priv->dev));

[Severity: Low]
Do the callback functions rproc_mem_entry_ioremap_wc() and
rproc_mem_entry_iounmap() exist in the tree? Passing undefined symbols here
will cause build failures.

[ ... ]
> +static int amd_bram_rproc_parse_fw(struct rproc *rproc,
> +				   const struct firmware *fw)
> +{
> +	rproc_elf_load_rsc_table_optional(rproc, fw, dev_dbg,
> +					  "no resource table found\n");
> +	return 0;
> +}

[Severity: Low]
Is rproc_elf_load_rsc_table_optional() defined in the kernel tree?

Additionally, because dev_dbg is a variadic macro, passing it as a function
pointer argument will result in preprocessor errors. Should this use a
different logging function or wrapper?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709145712.951146-1-ben.levinsky@amd.com?part=2