Re: [PATCH v5 2/7] dtc: dt-check-style: Allow space-aligning indentation in DTS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The check for excessive space characters (> 7) is not applied to continuation lines, allowing invalid mixed indentation to silently pass.
- [Low] Dead code: Unreachable `LineType.PREPROCESSOR` check inside continuation loop.
--

--- Patch [2]: [PATCH v5 2/7] dtc: dt-check-style: Allow space-aligning indentation in DTS ---
commit a9c24c0264c4f952c0bab2866c36e42454e6fbde
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Allow space-aligning indentation in DTS

This commit modifies the dt-check-style script to allow spaces after tabs
in DTS indentation for aligning continued lines. It limits spaces to a
maximum of 7 and explicitly disallows a space followed by a tab.

> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -359,14 +359,24 @@ def check_tab_in_yaml_example(ctx):
>  
>  
>  def check_mixed_indent_chars(ctx):
[ ... ]
> +        if dl.indent_str.count(' ') > 7:
> +            yield (dl.lineno, 'too many space characters in indent (more than 7)')
> +        for cont in dl.continuations:
> +            if not cont.indent_str:
> +                continue
> +            if cont.linetype == LineType.PREPROCESSOR:
> +                continue

[Severity: Low]
Are preprocessor lines possible in this continuation list? The logic that
builds the list seems to guarantee that continuations only ever contain
LineType.CONTINUATION elements, as preprocessor directives reset the
continuation state and are added to the main line list instead.

> +            if re.search(r' \t', cont.indent_str):
> +                yield (cont.lineno, 'mixed tabs and spaces in indent')

[Severity: Medium]
Should this loop over continuations also enforce the check for excessive
space characters? While the primary line is checked for more than 7 spaces
above, continuation lines omit this validation, which could allow invalid
mixed indentation to pass silently.

[ ... ]
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/bad/dts-mixed-indent.dts
> @@ -0,0 +1,21 @@
[ ... ]
> +		clocks = <1>,
> +  			 <2>,
> +			 <3>,
> +		         <4>;

[Severity: Medium]
Does the continuation line with value <4> contain 9 space characters?
Because the excessive space check is omitted for continuations in the
dt-check-style script, this 9-space indentation goes undetected.

> +		 resets = <5>;
> +	};
> +};
> diff --git a/scripts/dtc/dt-style-selftest/expected/dts-mixed-indent.dts.txt b/scripts/dtc/dt-style-selftest/expected/dts-mixed-indent.dts.txt
> new file mode 100644
> index 0000000000000..93146cfb51c78
> --- /dev/null
> +++ b/scripts/dtc/dt-style-selftest/expected/dts-mixed-indent.dts.txt
> @@ -0,0 +1,9 @@
[ ... ]
> +bad/dts-mixed-indent.dts:13: [mixed-indent-chars] mixed tabs and spaces in indent
> +bad/dts-mixed-indent.dts:16: [mixed-indent-chars] mixed tabs and spaces in indent
> +bad/dts-mixed-indent.dts:19: [indent-consistent] indent mismatch (expected depth 2 * '\t')

[Severity: Medium]
Should this expected output file also be updated once the excessive space
check is applied to the continuations loop? It currently fails to assert a
mixed-indent-chars warning for the 9-space continuation in the clocks
property above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-dts-style-checker-v5-0-fcc147cb697d@oss.qualcomm.com?part=2