Re: [PATCH v2 18/19] selftests: crypto: cmh - add kselftest for management ioctl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new selftests directory `drivers/crypto/cmh` is not added to the `TARGETS` list in the top-level selftests `Makefile`.
--

--- Patch [18]: [PATCH v2 18/19] selftests: crypto: cmh - add kselftest for management ioctl ---
commit c0e9965b4adefe82198fe9afe458b32c7561a9a3
Author: Alex Ousherovitch <aousherovitch@rambus.com>

selftests: crypto: cmh - add kselftest for management ioctl

This commit adds a minimal kselftest for the /dev/cmh_mgmt ioctl interface.
It exercises basic lifecycle events, input validation, and hardware key
generation capabilities.

> diff --git a/tools/testing/selftests/drivers/crypto/cmh/Makefile b/tools/testing/selftests/drivers/crypto/cmh/Makefile
> new file mode 100644
> index 0000000000000..86cb63839b27b
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/crypto/cmh/Makefile
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: GPL-2.0
> +TEST_GEN_PROGS := cmh_mgmt_test
> +
> +CFLAGS += -Wall -Wno-misleading-indentation -O2 $(KHDR_INCLUDES)
> +
> +include ../../../lib.mk

[Severity: Medium]
Is this new test directory missing from the TARGETS list in the top-level
tools/testing/selftests/Makefile?

Without being added to TARGETS (e.g., TARGETS += drivers/crypto/cmh), it
appears this test won't be automatically built, installed, or executed when
running standard automated frameworks like `make kselftest`.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709203037.1884436-1-skrishnamoorthy@rambus.com?part=18