Re: [PATCH v3 1/2] dt-bindings: thermal: imx: Document calibration offset property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly documented `fsl,temp-calibration-offset-millicelsius` device tree property is not implemented in the corresponding thermal driver.
--

--- Patch [1]: [PATCH v3 1/2] dt-bindings: thermal: imx: Document calibration offset property ---
commit fabff9a1c8bc1005fe350da46dd065d5e508aee0
Author: HaoNing Cheng <Haoning.CHENG@cn.bosch.com>

dt-bindings: thermal: imx: Document calibration offset property

Some boards need a small per-design correction to align the reported CPU
temperature with board-level measurements. Document the optional
fsl,temp-calibration-offset-millicelsius property, a signed offset in
millicelsius that is added to the calculated sensor temperature. Update the
binding example to show its usage.

> diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> index 949b154856c53..704bf2fa48cf5 100644
> --- a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> @@ -59,6 +59,15 @@ properties:
>    clocks:
>      maxItems: 1
>  
> +  fsl,temp-calibration-offset-millicelsius:
> +    maxItems: 1
> +    description:
> +      A signed calibration offset, in millicelsius, added to the calculated

[Severity: Medium]
Is this property actually implemented in the corresponding thermal driver?

Without parsing and applying this offset in the C code, the device tree
property will be silently ignored when provided by the boot environment.
This could result in incorrect temperature readings for boards relying on
this calibration, potentially leading to premature or delayed thermal
throttling.

> +      sensor temperature to compensate for board-level measurement
> +      differences. When absent, no offset is applied.
> +    minimum: -28580
> +    maximum: 28580
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-b4-symana21-11221-imx-thermal-support-upstream-6-18-v3-0-db9fc2947c55@cn.bosch.com?part=1