Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: Remove camera_front_active pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removal of explicit electrical pin configuration for camera reset GPIO
--

--- Patch [1]: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: Remove camera_front_active pinctrl ---
commit 0022e4fa862c463785a16fefb223c9ad61f2fc67
Author: Xin Xu <xxsemail@qq.com>

arm64: dts: qcom: sm8250-xiaomi-elish: Remove camera_front_active pinctrl

This commit removes the camera_front_active pinctrl node and its reference,
stating that the GPIO 109 configuration duplicates the reset-gpios property.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index 19aff83ecf7b6..26801d6a1ec5f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -570,7 +570,7 @@ camera_front: camera@10 {
>  
>  		reset-gpios = <&tlmm 109 GPIO_ACTIVE_LOW>;
>  
> -		pinctrl-0 = <&cam_mclk3_default &camera_front_active>;
> +		pinctrl-0 = <&cam_mclk3_default>;
>  		pinctrl-names = "default";
>  
>  		orientation = <0>; /* Front facing */

[ ... ]

> @@ -947,13 +947,6 @@ pm8008_reset_default: pm8008-reset-default-state {
>  		bias-pull-up;
>  	};
>  
> -	camera_front_active: camera-front-active-state {
> -		pins = "gpio109";
> -		function = "gpio";
> -		drive-strength = <2>;
> -		bias-disable;
> -	};
> -

[Severity: Medium]
Does removing this pinctrl node leave the pin without a guaranteed electrical
configuration?

The reset-gpios property configures pin routing and logical polarity, but it
doesn't apply explicit electrical properties like drive-strength and
bias-disable.

If the bootloader leaves a pull-up or pull-down resistor enabled on this GPIO,
could the GPIO output driver end up fighting it and causing constant power
leakage?

>  	wlan_en_state: wlan-default-state {
>  		pins = "gpio20";
>  		function = "gpio";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_AEB4238D8669271E5C1CD19C2C61A45AD108@qq.com?part=1