From: sashiko-bot@kernel.org
To: "Manuel Ebner" <manuelebner@mailbox.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
wsa+renesas@sang-engineering.com, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket
Date: Fri, 10 Jul 2026 09:00:39 +0000 [thread overview]
Message-ID: <20260710090039.7EE011F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260710085744.430340-2-manuelebner@mailbox.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message subject incorrectly identifies the modified subsystem and hardware as `arm: qcom,coresight-tpdm` instead of `clock: renesas,rcar-usb2-clock-sel`.
--
--- Patch [1]: [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket ---
commit 4518c7688f32a888db4924e5e78556acf8a513d9
Author: Manuel Ebner <manuelebner@mailbox.org>
dt-bindings: arm: qcom,coresight-tpdm: fix bracket
This commit fixes a missing bracket and adjusts the sentence structure in a
device tree binding description.
> dt-bindings: arm: qcom,coresight-tpdm: fix bracket
[Severity: Medium]
Is the commit subject line correct for this change? The patch actually modifies
Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml,
but the subject references arm: qcom,coresight-tpdm. Should the subject
be updated to match the modified renesas clock bindings?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260710085744.430340-2-manuelebner@mailbox.org?part=1
next prev parent reply other threads:[~2026-07-10 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 8:57 [PATCH] dt-bindings: arm: qcom,coresight-tpdm: fix bracket Manuel Ebner
2026-07-10 9:00 ` sashiko-bot [this message]
2026-07-10 9:43 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2026-07-10 8:05 Manuel Ebner
2026-07-11 0:46 ` Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710090039.7EE011F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=manuelebner@mailbox.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox