Re: [PATCH v4 3/7] media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The patch series introduces a new V4L2 meta format `V4L2_META_FMT_QCOM_ISP_PARAMS` but fails to include the required UAPI header (`include/uapi/linux/camss-config.h`).
- [Low] The newly introduced V4L2 meta format `V4L2_META_FMT_QCOM_ISP_PARAMS` lacks required UAPI documentation.
--

--- Patch [3]: [PATCH v4 3/7] media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters ---
commit 83fc58abbbf229c34d9df1193ba64e7a8a63b269
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters

This commit adds a V4L2 meta format code (V4L2_META_FMT_QCOM_ISP_PARAMS)
for the Qualcomm CAMSS ISP parameter buffer. It allows carrying per-frame
ISP tuning data such as white balance, color correction, and chroma
enhancement settings.

> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index eda4492e40dc1..ee3a56f379d40 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -889,6 +889,9 @@ struct v4l2_pix_format {
>  #define V4L2_META_FMT_MALI_C55_PARAMS	v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */
>  #define V4L2_META_FMT_MALI_C55_STATS	v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */
>  
> +/* Vendor specific - used for Qualcomm CAMSS offline ISP */
> +#define V4L2_META_FMT_QCOM_ISP_PARAMS	v4l2_fourcc('Q', 'C', 'I', 'P') /* Qualcomm CAMSS ISP */

[Severity: Low]
Is the UAPI header defining the payload for this format missing from the patch
series?

The driver code appears to rely on structs like camss_params_wb_gain that
would normally be defined in include/uapi/linux/camss-config.h. Without this
header, including the definitions in camss-params.h will lead to undefined
type errors during compilation.

[Severity: Low]
Should this new format be accompanied by V4L2 UAPI documentation?

The V4L2 subsystem requires new formats to have their purpose, layout, and
semantics documented, but there doesn't appear to be an update to the media
documentation for V4L2_META_FMT_QCOM_ISP_PARAMS.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-camss-isp-ope-v4-0-51207a0319d8@oss.qualcomm.com?part=3