Re: [PATCH v2 1/3] dt-bindings: mfd: x-powers,axp152: Document AXP318W

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema validation will falsely reject `dcdc8` and `dcdc9` nodes because the regex for regulators was not updated to include them.
--

--- Patch [1]: [PATCH v2 1/3] dt-bindings: mfd: x-powers,axp152: Document AXP318W ---
commit fba0de88525a2ca51e0528a24ed28b5ca4ccd346
Author: Andre Przywara <andre.przywara@arm.com>

dt-bindings: mfd: x-powers,axp152: Document AXP318W

This commit documents the AXP318W PMIC, adding its compatible string and
input supply properties. It includes new power supply nodes like vin19-supply
and vin678-supply, and adds swout1/swout2 to the regulator node name pattern.

> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> index 45f015d63df16..1bed19fc91ec4 100644
> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> @@ -156,10 +158,18 @@ properties:
>      description: >
>        DCDC1 power supply node, if present.
>  
> +  vin19-supply:
> +    description: >
> +      Combined DCDC1/DCDC9 power supply node, if present.

[ ... ]

> @@ -176,6 +190,10 @@ properties:
>      description: >
>        DCDC6 power supply node, if present.
>  
> +  vin678-supply:
> +    description: >
> +      Combined DCDC6/DCDC7/DCDC8 power supply node, if present.

[ ... ]

> @@ -277,7 +303,7 @@ properties:
>            Defines the work frequency of DC-DC in kHz.
>  
>      patternProperties:
> -      "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo|boost)$":
> +      "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|swout[1-9]|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo|boost)$":

[Severity: Medium]
Will this regex falsely reject dcdc8 and dcdc9 nodes? The commit adds
vin19-supply (for DCDC1/DCDC9) and vin678-supply (for DCDC6/DCDC7/DCDC8), but
the regex dcdc[0-7a-e] only matches 0-7 and a-e, excluding 8 and 9.

This could cause device trees configuring these new regulators to fail
schema validation.

>          $ref: /schemas/regulator/regulator.yaml#
>          type: object
>          unevaluatedProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-axp318-regulator-v2-0-ee5f1c56b49f@baylibre.com?part=1