Re: [PATCH v3 2/3] arm64: dts: ti: Add support for Variscite VAR-SOM-AM62

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `main_i2c3` interface is enabled by default in the SOM device tree without any attached SOM-specific child peripherals, contradicting the commit message's design rule.
--

--- Patch [2]: [PATCH v3 2/3] arm64: dts: ti: Add support for Variscite VAR-SOM-AM62 ---
commit b50e7e0d210badd0bd12a9c466cdaf9cdf2bfcaf
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: ti: Add support for Variscite VAR-SOM-AM62

Add device tree support for the Variscite VAR-SOM-AM62 system on module.
This SOM is designed to be used with various carrier boards.

Link: https://variscite.com/system-on-module-som/ti-sitara-am62x/var-som-am62/

> diff --git a/arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi b/arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi
> new file mode 100644
> index 0000000000000..c2daa56c35e17
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am625-var-som.dtsi

[ ... ]

> +&main_i2c3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c3>;
> +	clock-frequency = <400000>;
> +	status = "okay";
> +};
> +

[Severity: Medium]
The commit message states: "Only SOM-specific peripherals are enabled by
default. Carrier board specific interfaces are left disabled to be enabled in
the respective carrier board device trees."

However, main_i2c3 is enabled here with no SOM-specific child peripherals
attached. Should this interface be left disabled by default to allow carrier
boards to use these pins (e.g., for UART0 CTS/RTS) without having to explicitly
disable main_i2c3 first?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783689915.git.stefano.r@variscite.com?part=2